[GitHub] drcrallen commented on a change in pull request #6629: Add support parallel combine in brokers

[GitBox <gi...@apache.org>]

drcrallen commented on a change in pull request #6629: Add support parallel combine in brokers
URL: https://github.com/apache/incubator-druid/pull/6629#discussion_r240734226
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/collections/BlockingPool.java
 ##########
 @@ -24,8 +24,21 @@
 
 public interface BlockingPool<T>
 {
+  /**
+   * Returns the total pool size.
+   */
   int maxSize();
 
+  /**
+   * Returns the number of current available resources.
+   */
+  int available();
+
+  /**
+   * Poll all available resources from the pool. If there's no available resource, it returns an empty list.
 
 Review comment:
   The `BlockingQueue` interface has a `drainTo` method that does something similar. Can you add documentation on how the behavior of this method is similar or different compared to `drainTo`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org