[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1211: DISPATCH-836 Add a .c file for every (non-private) include file

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #1211:
URL: https://github.com/apache/qpid-dispatch/pull/1211#discussion_r630524658



##########
File path: src/CMakeLists.txt
##########
@@ -101,25 +111,28 @@ set(qpid_dispatch_SOURCES
   router_core/terminus.c
   router_core/transfer.c
   router_core/core_timer.c
+  router_core/module.c
   router_core/modules/edge_router/module.c
   router_core/modules/edge_router/addr_proxy.c
   router_core/modules/edge_router/connection_manager.c
   router_core/modules/edge_router/link_route_proxy.c
   router_core/modules/edge_router/edge_mgmt.c
   router_core/modules/test_hooks/core_test_hooks.c
   router_core/modules/edge_addr_tracking/edge_addr_tracking.c
-  router_core/modules/address_lookup_server/address_lookup_server.c
+  router_core/modules/address_lookup_server/address_lookup_utils.c

Review comment:
       Yeah, I did not handle this well. At least, I need to change the include guard in the header file. Not sure what's the appropriate name, only know that the name of c and h files should match.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org