You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/01 10:15:16 UTC
[GitHub] [tvm] echuraev opened a new pull request #7960: Fix a memory leak in SetParams
echuraev opened a new pull request #7960:
URL: https://github.com/apache/tvm/pull/7960
ToDLPack creates a DLManagedTensor instance, but nobody delete this i8n
proper way. We can use operator-> for getting access to DLTensor.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on pull request #7960: Fix a memory leak in SetParams
Posted by GitBox <gi...@apache.org>.
echuraev commented on pull request #7960:
URL: https://github.com/apache/tvm/pull/7960#issuecomment-830619896
> Thanks @echuraev can you also search the usage of ToDLPack() and update other locations? Likely they will also cause memleak
Done. Find all other usages of `ToDLPack()` and remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7960: Fix a memory leak in SetParams
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7960:
URL: https://github.com/apache/tvm/pull/7960#issuecomment-830706549
Thanks @echuraev !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7960: Fix a memory leak in SetParams
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7960:
URL: https://github.com/apache/tvm/pull/7960#issuecomment-830617945
Thanks @echuraev can you also search the usage of ToDLPack() and update other locations? Likely they will also cause memleak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev edited a comment on pull request #7960: Fix a memory leak in SetParams
Posted by GitBox <gi...@apache.org>.
echuraev edited a comment on pull request #7960:
URL: https://github.com/apache/tvm/pull/7960#issuecomment-830619896
> Thanks @echuraev can you also search the usage of ToDLPack() and update other locations? Likely they will also cause memleak
Done. Found all other usages of `ToDLPack()` and removed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #7960: Fix a memory leak in SetParams
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7960:
URL: https://github.com/apache/tvm/pull/7960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org