You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Lucas Galfaso (JIRA)" <ji...@apache.org> on 2007/11/30 02:39:43 UTC

[jira] Created: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Bundle-Classpath is not working with directories as expected.
-------------------------------------------------------------

                 Key: FELIX-426
                 URL: https://issues.apache.org/jira/browse/FELIX-426
             Project: Felix
          Issue Type: Bug
          Components: Framework
    Affects Versions: 1.0.0
         Environment: Windows XP / Ubuntu Linux
            Reporter: Lucas Galfaso


The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: Patch proposition - UPnP Base Driver

Posted by Francesco Furfari <fr...@isti.cnr.it>.
Dear Andre,
thank you very much for the patches you attached.
(for the community I received the files in another message as the mail 
system has filtered them)

The changes concern the patched Cyberlink library which is maintained in 
   another repository. I forwarded the files to Stefano and they will be 
likely applied to the version 1.8.

thanks again
francesco




BOTTARO Andre RD-MAPS-GRE wrote:
> Thanks to a colleague, our patched version of the UPnP Base Driver now enables our OSGi applications to interoperate with several real devices that are standard UPnP Media Servers. Here are the classes and a description of the patch.
> 
> --------------------------
> 
> 1.	Problem introduction 
> Apache Felix UPnP Base Driver doesn't enable osgi applications to correctly browse (UPnP AV Content Directory Service action named browse) media files present on several devices in particular these ones:
> -	Quartek Qbox
> -	Philips Media Manager
> Sending the 'browse' action on the CDS service of these UPnP devices, Apache Felix UPnP Base Driver return a null object.
> 
> 
> 2.	Problem analysis
> Sniffing http packet on the network, we see that these servers don't return all variable that the Apache Felix UPnP Base Driver wait for. Indeed, the Media Servers don't return the constant "CONTENT-LENGTH" in HTTP packets and the HTTP message parsing is obviously skipped by the cyberlink UPnP stack that is embedded in the Apache Felix UPnP Base Driver. Then the result of the "browse" action appears to be null. Although this problem was raised by the browse action that is critical in our application, the problem would probable have occured with other action calls.
> 
> 
> 3.	Solution
> In order to resolve this problem, 2 Java(tm) classes in distinct packages are modified.
> 
> The objective is first to initialize the "CONTENT-LENGTH" variable with a value big enough to contain all the possible values in UPnP applications. 
> We declare a constant "conlen" initially assigned to 999999999. It thus simulates a big "CONTENT-LENGTH" for the browse action response to be parsed and the media controller can correctly browse Media servers. This change is made in HTTPPacket.set(InputStream in, boolean onlyHeaders) method (org.cybergarage.http package).
> 
> The Action.postControlAction() method (org.cybergarage.upnp package) is also changed to use the new method HTTPPacket.set().
> 
> --
> André
> 

Patch proposition - UPnP Base Driver

Posted by BOTTARO Andre RD-MAPS-GRE <an...@orange-ftgroup.com>.
Thanks to a colleague, our patched version of the UPnP Base Driver now enables our OSGi applications to interoperate with several real devices that are standard UPnP Media Servers. Here are the classes and a description of the patch.

--------------------------

1.	Problem introduction 
Apache Felix UPnP Base Driver doesn't enable osgi applications to correctly browse (UPnP AV Content Directory Service action named browse) media files present on several devices in particular these ones:
-	Quartek Qbox
-	Philips Media Manager
Sending the 'browse' action on the CDS service of these UPnP devices, Apache Felix UPnP Base Driver return a null object.


2.	Problem analysis
Sniffing http packet on the network, we see that these servers don't return all variable that the Apache Felix UPnP Base Driver wait for. Indeed, the Media Servers don't return the constant "CONTENT-LENGTH" in HTTP packets and the HTTP message parsing is obviously skipped by the cyberlink UPnP stack that is embedded in the Apache Felix UPnP Base Driver. Then the result of the "browse" action appears to be null. Although this problem was raised by the browse action that is critical in our application, the problem would probable have occured with other action calls.


3.	Solution
In order to resolve this problem, 2 Java(tm) classes in distinct packages are modified.

The objective is first to initialize the "CONTENT-LENGTH" variable with a value big enough to contain all the possible values in UPnP applications. 
We declare a constant "conlen" initially assigned to 999999999. It thus simulates a big "CONTENT-LENGTH" for the browse action response to be parsed and the media controller can correctly browse Media servers. This change is made in HTTPPacket.set(InputStream in, boolean onlyHeaders) method (org.cybergarage.http package).

The Action.postControlAction() method (org.cybergarage.upnp package) is also changed to use the new method HTTPPacket.set().

--
André


[jira] Updated: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Lucas Galfaso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lucas Galfaso updated FELIX-426:
--------------------------------

    Attachment: FELIX-426.patch

Better patch.

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555641#action_12555641 ] 

Richard S. Hall commented on FELIX-426:
---------------------------------------

I created a simple bundle with the following structure:

   META-INF/MANIFEST.MF
   org/apache/felix/test/classloading/Activator.class
   classpath/org/apache/felix/test/classloading/directory/Hello.class

And with:

   Bundle-ClassPath: .,classpath

My activator was able to create an instance of Hello, so the simple case appears to be working. I definitely need more help to reproduce any issues.

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall updated FELIX-426:
----------------------------------

    Attachment: FELIX-426.v4.patch

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.v2.patch, FELIX-426.v3.patch, FELIX-426.v4.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Lucas Galfaso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lucas Galfaso updated FELIX-426:
--------------------------------

    Attachment: FELIX-426.v2.patch

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.v2.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Richard S. Hall" <he...@ungoverned.org>.
Thanks. I will review the patch and try to apply it quickly.

-> richard

Lucas Galfaso (JIRA) wrote:
>     [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555647#action_12555647 ] 
>
> Lucas Galfaso commented on FELIX-426:
> -------------------------------------
>
> Hi Richard,
>   If you set
>
> Bundle-Classpath: .,/classpath
>
> then it fails. Also ContentDirectoryContent::EntriesEnumeration is really broken as it returns a lot of false positives. I am attaching a patch for both issues in five minutes.
>
>   
>> Bundle-Classpath is not working with directories as expected.
>> -------------------------------------------------------------
>>
>>                 Key: FELIX-426
>>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>>             Project: Felix
>>          Issue Type: Bug
>>          Components: Framework
>>    Affects Versions: 1.0.0
>>         Environment: Windows XP / Ubuntu Linux
>>            Reporter: Lucas Galfaso
>>         Attachments: FELIX-426.patch
>>
>>
>> The manifest entry Bundle-Classpath is not working as expected when directories are specified.
>>     
>
>   

[jira] Commented: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Lucas Galfaso (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555647#action_12555647 ] 

Lucas Galfaso commented on FELIX-426:
-------------------------------------

Hi Richard,
  If you set

Bundle-Classpath: .,/classpath

then it fails. Also ContentDirectoryContent::EntriesEnumeration is really broken as it returns a lot of false positives. I am attaching a patch for both issues in five minutes.

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Lucas Galfaso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lucas Galfaso updated FELIX-426:
--------------------------------

    Attachment:     (was: FELIX-426.patch)

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Lucas Galfaso (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555678#action_12555678 ] 

Lucas Galfaso commented on FELIX-426:
-------------------------------------

The patch does solve the other issue, thanks

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.v2.patch, FELIX-426.v3.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555670#action_12555670 ] 

Richard S. Hall commented on FELIX-426:
---------------------------------------

Lucas, I agree it looks like it would return false positives, but were you actually running into this issue? I am trying to think of the case when someone would actually see the error, since I don't think it is used by Felix...or did you just happen to notice that it was in error?

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.v2.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555615#action_12555615 ] 

Richard S. Hall commented on FELIX-426:
---------------------------------------

Lucas, could you be more precise about the issue you were seeing?

I am not sure your patch will work in general since it modifies JarContent directly, which will likely mean that it will only work for bundles that are packaged as a JAR file. Felix also supports bundles as exploded directories (i.e., DirectoryContent), which is why we have ContentDirectoryContent (dumb name, I know) in the first place, which is used so that content can be provided from the directory of another content.

So, I think we need to fix ContentDirectoryContent if there is a bug in it, not eliminate it.

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555848#action_12555848 ] 

Felix Meschberger commented on FELIX-426:
-----------------------------------------

Sorry, to jump in here, but:

> The patch to ContentDirectoryContent::EntriesEnumeration does not look right as
> public boolean hasMoreElements()
> might return true when there are no elements left.

According to the JavaDoc of Enumeration.hasMoreElements(), which is AFAIK normative: 

    /**
     * Tests if this enumeration contains more elements.
     *
     * @return  <code>true</code> if and only if this enumeration object
     *           contains at least one more element to provide;
     *          <code>false</code> otherwise.
     */
    boolean hasMoreElements();

this method only returns true, if there is at least one more element to be retreived by Enumeration.nextElement(). If this would not be the case, the respective implementation would be wrong .... (and not the use of it)

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.v2.patch, FELIX-426.v3.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Lucas Galfaso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lucas Galfaso updated FELIX-426:
--------------------------------

    Attachment: FELIX-426.patch

Attaching patch for this issue. This patch should make the class ContentDirectoryContent unnecesary (unless it is used outside the framework.)

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555944#action_12555944 ] 

Richard S. Hall commented on FELIX-426:
---------------------------------------

Yes, Lucas, you are definitely correct, my patch didn't fix that from the original. I have attached a modified patch, which I believe is correct with respect to hasMoreElements() and will correctly throw an exception in nextElement() when there are no more elements.

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.v2.patch, FELIX-426.v3.patch, FELIX-426.v4.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall updated FELIX-426:
----------------------------------

    Attachment: FELIX-426.v3.patch

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.v2.patch, FELIX-426.v3.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Lucas Galfaso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lucas Galfaso updated FELIX-426:
--------------------------------

    Attachment:     (was: FELIX-426.patch)

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall resolved FELIX-426.
-----------------------------------

    Resolution: Fixed
      Assignee: Richard S. Hall

I have committed the v4 patch for this. Lucas, please close it if you are satisfied with the solution. Thanks for the help.

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>            Assignee: Richard S. Hall
>         Attachments: FELIX-426.v2.patch, FELIX-426.v3.patch, FELIX-426.v4.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555673#action_12555673 ] 

Richard S. Hall commented on FELIX-426:
---------------------------------------

Lucas, I attached a modified version of your patch. Let me know if it sufficiently resolves the issues you discovered. If so, I will commit it. Thanks.

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.v2.patch, FELIX-426.v3.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-426) Bundle-Classpath is not working with directories as expected.

Posted by "Lucas Galfaso (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555677#action_12555677 ] 

Lucas Galfaso commented on FELIX-426:
-------------------------------------

I am not running into the ContentDirectoryContent::EntriesEnumeration issue (I was running into the other issue) it just happened that I notice the bug while checking ContentDirectoryContent. Anyhow, I think I can force the issue, but I am not sure.

The patch to ContentDirectoryContent::EntriesEnumeration does not look right as
public boolean hasMoreElements()
might return true when there are no elements left.

> Bundle-Classpath is not working with directories as expected.
> -------------------------------------------------------------
>
>                 Key: FELIX-426
>                 URL: https://issues.apache.org/jira/browse/FELIX-426
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 1.0.0
>         Environment: Windows XP / Ubuntu Linux
>            Reporter: Lucas Galfaso
>         Attachments: FELIX-426.v2.patch, FELIX-426.v3.patch
>
>
> The manifest entry Bundle-Classpath is not working as expected when directories are specified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.