You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/08 20:08:06 UTC
[GitHub] [beam] ahmedabu98 opened a new pull request, #22624: Pass user specified destination type to UpdateSchemaDestination
ahmedabu98 opened a new pull request, #22624:
URL: https://github.com/apache/beam/pull/22624
Fixes #22543
When using multiple partitions for a BigQuery `FILE_LOADS` write, the user's dynamic destination type isn't properly passed into `UpdateSchemaDestination`. This leads to a `ClassCastException` when attempting to get the table and schema using the dynamic destination object.
The user's dynamic destination object is configured with a particular parameter type (represented by `DestinationT`) for `getTable()` and `getSchema` (see [here](https://github.com/apache/beam/blob/70cee1d125db0b62b2d660fc399e5a23845eb0e3/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/DynamicDestinations.java#L147-L155)). The current implementation doesn't respect this user type and instead passes in a fixed TableDestination argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22624: Pass user specified destination type to UpdateSchemaDestination
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22624:
URL: https://github.com/apache/beam/pull/22624#issuecomment-1208563662
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #22624: Pass user specified destination type to UpdateSchemaDestination
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #22624:
URL: https://github.com/apache/beam/pull/22624#issuecomment-1213139268
This LGTM. Have you retried the original failing custom dynamic destinations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #22624: Pass user specified destination type to UpdateSchemaDestination
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #22624:
URL: https://github.com/apache/beam/pull/22624#issuecomment-1213147389
Yup, left a comment in #22543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #22624: Pass user specified destination type to UpdateSchemaDestination
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #22624:
URL: https://github.com/apache/beam/pull/22624#issuecomment-1208562403
R: @johnjcasey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #22624: Pass user specified destination type to UpdateSchemaDestination
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #22624:
URL: https://github.com/apache/beam/pull/22624#issuecomment-1208562063
Run PostCommit_Java_DataflowV2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey merged pull request #22624: Pass user specified destination type to UpdateSchemaDestination
Posted by GitBox <gi...@apache.org>.
johnjcasey merged PR #22624:
URL: https://github.com/apache/beam/pull/22624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #22624: Pass user specified destination type to UpdateSchemaDestination
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #22624:
URL: https://github.com/apache/beam/pull/22624#issuecomment-1212569131
Run PostCommit_Java_DataflowV2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org