You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/26 08:46:57 UTC

[GitHub] [spark] beliefer commented on a change in pull request #33822: [SPARK-36574][SQL] pushDownPredicate=false failed to prevent push down filters to JDBC data source

beliefer commented on a change in pull request #33822:
URL: https://github.com/apache/spark/pull/33822#discussion_r696424411



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -409,7 +409,7 @@ object DataSourceStrategy
         pushedFilters.toSet,
         handledFilters,
         None,
-        scanBuilder(requestedColumns, candidatePredicates, pushedFilters),
+        scanBuilder(requestedColumns, candidatePredicates, handledFilters.toSeq),

Review comment:
       OK. Let me revert it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org