You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ha...@apache.org on 2021/05/12 13:50:48 UTC

[iotdb] branch JDK16 updated: change UDF and trigger pom

This is an automated email from the ASF dual-hosted git repository.

haonan pushed a commit to branch JDK16
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/JDK16 by this push:
     new 7ef4f87  change UDF and trigger pom
7ef4f87 is described below

commit 7ef4f87e60d4da443b12f8410ebe6838b0fd74d8
Author: HTHou <hh...@outlook.com>
AuthorDate: Wed May 12 21:49:44 2021 +0800

    change UDF and trigger pom
---
 example/trigger/pom.xml | 66 ++++++++++++++++++++++++++++++-------------------
 example/udf/pom.xml     | 66 ++++++++++++++++++++++++++++++-------------------
 pom.xml                 | 18 +++++++++++---
 3 files changed, 94 insertions(+), 56 deletions(-)

diff --git a/example/trigger/pom.xml b/example/trigger/pom.xml
index 9d82b97..40db452 100644
--- a/example/trigger/pom.xml
+++ b/example/trigger/pom.xml
@@ -64,32 +64,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>com.diffplug.spotless</groupId>
-                <artifactId>spotless-maven-plugin</artifactId>
-                <version>2.4.2</version>
-                <configuration>
-                    <java>
-                        <googleJavaFormat>
-                            <version>1.7</version>
-                            <style>GOOGLE</style>
-                        </googleJavaFormat>
-                        <importOrder>
-                            <order>org.apache.iotdb,,javax,java,\#</order>
-                        </importOrder>
-                        <removeUnusedImports/>
-                    </java>
-                </configuration>
-                <executions>
-                    <execution>
-                        <id>spotless-check</id>
-                        <phase>validate</phase>
-                        <goals>
-                            <goal>check</goal>
-                        </goals>
-                    </execution>
-                </executions>
-            </plugin>
         </plugins>
     </build>
     <profiles>
@@ -120,5 +94,45 @@
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>spotless</id>
+            <activation>
+                <jdk>[1.8,16)</jdk>
+                <!-- activeByDefault does not take effect-->
+                <file>
+                    <exists>.</exists>
+                </file>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>com.diffplug.spotless</groupId>
+                        <artifactId>spotless-maven-plugin</artifactId>
+                        <version>2.4.2</version>
+                        <configuration>
+                            <java>
+                                <googleJavaFormat>
+                                    <version>1.7</version>
+                                    <style>GOOGLE</style>
+                                </googleJavaFormat>
+                                <importOrder>
+                                    <order>org.apache.iotdb,,javax,java,\#</order>
+                                </importOrder>
+                                <removeUnusedImports/>
+                            </java>
+                        </configuration>
+                        <executions>
+                            <execution>
+                                <id>spotless-check</id>
+                                <phase>validate</phase>
+                                <goals>
+                                    <goal>check</goal>
+                                </goals>
+                            </execution>
+                        </executions>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
     </profiles>
 </project>
diff --git a/example/udf/pom.xml b/example/udf/pom.xml
index 4439eea..636c7da 100644
--- a/example/udf/pom.xml
+++ b/example/udf/pom.xml
@@ -64,32 +64,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>com.diffplug.spotless</groupId>
-                <artifactId>spotless-maven-plugin</artifactId>
-                <version>2.4.2</version>
-                <configuration>
-                    <java>
-                        <googleJavaFormat>
-                            <version>1.7</version>
-                            <style>GOOGLE</style>
-                        </googleJavaFormat>
-                        <importOrder>
-                            <order>org.apache.iotdb,,javax,java,\#</order>
-                        </importOrder>
-                        <removeUnusedImports/>
-                    </java>
-                </configuration>
-                <executions>
-                    <execution>
-                        <id>spotless-check</id>
-                        <phase>validate</phase>
-                        <goals>
-                            <goal>check</goal>
-                        </goals>
-                    </execution>
-                </executions>
-            </plugin>
         </plugins>
     </build>
     <profiles>
@@ -120,5 +94,45 @@
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>spotless</id>
+            <activation>
+                <jdk>[1.8,16)</jdk>
+                <!-- activeByDefault does not take effect-->
+                <file>
+                    <exists>.</exists>
+                </file>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>com.diffplug.spotless</groupId>
+                        <artifactId>spotless-maven-plugin</artifactId>
+                        <version>2.4.2</version>
+                        <configuration>
+                            <java>
+                                <googleJavaFormat>
+                                    <version>1.7</version>
+                                    <style>GOOGLE</style>
+                                </googleJavaFormat>
+                                <importOrder>
+                                    <order>org.apache.iotdb,,javax,java,\#</order>
+                                </importOrder>
+                                <removeUnusedImports/>
+                            </java>
+                        </configuration>
+                        <executions>
+                            <execution>
+                                <id>spotless-check</id>
+                                <phase>validate</phase>
+                                <goals>
+                                    <goal>check</goal>
+                                </goals>
+                            </execution>
+                        </executions>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
     </profiles>
 </project>
diff --git a/pom.xml b/pom.xml
index 97b9130..d4d43c9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -149,13 +149,13 @@
         <sonar.coverage.jacoco.xmlReportPaths>target/jacoco-merged-reports/jacoco.xml</sonar.coverage.jacoco.xmlReportPaths>
         <sonar.junit.reportPaths>target/surefire-reports,target/failsafe-reports</sonar.junit.reportPaths>
         <!-- By default, the argLine is empty-->
+        <argLine/>
         <gson.version>2.8.6</gson.version>
         <!-- whether enable compiling the cpp client-->
         <client-cpp>false</client-cpp>
         <!-- disable enforcer by default-->
         <enforcer.skip>true</enforcer.skip>
         <spotless.version>2.4.2</spotless.version>
-        <argLine>--illegal-access=permit --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED [...]
     </properties>
     <!--
         if we claim dependencies in dependencyManagement, then we do not claim
@@ -945,12 +945,11 @@
         </plugins>
     </build>
     <profiles>
-        <!-- spotless is too slow, so we put it into a profile to skip it if needed -->
+        <!-- currently spotless cannot run on jdk16 -->
         <profile>
             <id>spotless</id>
             <activation>
-                <jdk>[8,16)</jdk>
-                <!-- activeByDefault does not take effect-->
+                <jdk>[1.8,16)</jdk>
                 <file>
                     <exists>.</exists>
                 </file>
@@ -1067,6 +1066,17 @@
                 </dependency>
             </dependencies>
         </profile>
+        <profile>
+            <id>java-16-and-above</id>
+            <activation>
+                <!-- This needs to be updated as soon as Java 20 is shipped -->
+                <jdk>[16,20)</jdk>
+            </activation>
+            <properties>
+                <maven.compiler.release>8</maven.compiler.release>
+                <argLine>--illegal-access=permit --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL [...]
+            </properties>
+        </profile>
         <!--
           Self activating profile, that activates itself as soon as a "src/main/thrift" directory is found.
           The different plugins here download the thrift executable matching the current os, make that