You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/05/03 00:57:56 UTC
Review Request 46917: GEODE-625: Adding tests for exception handling
of functions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46917/
-----------------------------------------------------------
Review request for geode, anilkumar gingade and nabarun nag.
Repository: geode
Description
-------
Testing how functions propagate exceptions from within the function to
the caller or the result collector.
Fixing a bug in exception propegation discovered while writing these tests.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java 57b1e71e8a5591e74f11041c916ed5cec1a8fd29
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceBase.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceLocalPRDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceLocalRRDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceMultipleOnMemberDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceRemotePRDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceRemoteRRDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceSingleOnMemberDUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/46917/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 46917: GEODE-625: Adding tests for exception
handling of functions
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46917/#review131559
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Huynh
On May 3, 2016, 1:03 a.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46917/
> -----------------------------------------------------------
>
> (Updated May 3, 2016, 1:03 a.m.)
>
>
> Review request for geode, anilkumar gingade and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Testing how functions propagate exceptions from within the function to
> the caller or the result collector.
>
> Fixing a bug in exception propegation discovered while writing these tests.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java 57b1e71e8a5591e74f11041c916ed5cec1a8fd29
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceBase.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceLocalPRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceLocalRRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceMultipleOnMemberDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServicePeerAccessorPRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServicePeerAccessorRRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceSingleOnMemberDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46917/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 46917: GEODE-625: Adding tests for exception
handling of functions
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46917/
-----------------------------------------------------------
(Updated May 3, 2016, 1:03 a.m.)
Review request for geode, anilkumar gingade and nabarun nag.
Changes
-------
Appying review comments from Jason, Naba - using ExpectedException in the tests instead of @Test(expected = ...)
Repository: geode
Description
-------
Testing how functions propagate exceptions from within the function to
the caller or the result collector.
Fixing a bug in exception propegation discovered while writing these tests.
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java 57b1e71e8a5591e74f11041c916ed5cec1a8fd29
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceBase.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceLocalPRDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceLocalRRDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceMultipleOnMemberDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServicePeerAccessorPRDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServicePeerAccessorRRDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceSingleOnMemberDUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/46917/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 46917: GEODE-625: Adding tests for exception
handling of functions
Posted by Dan Smith <ds...@pivotal.io>.
> On May 2, 2016, 11:38 p.m., Jason Huynh wrote:
> > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceBase.java, line 65
> > <https://reviews.apache.org/r/46917/diff/1/?file=1369317#file1369317line65>
> >
> > Do we care about the message in the functionexception?
> >
> > If so, instead of using the expected = FunctionException.class annotation, we can do:
> >
> > //class variable
> > public ExpectedException expectedException = ExpectedException.none();
> >
> > //in each test
> > expectedException.expect(SomeException.class);
> > expectedException.expectMessage("Some message");
Good point. I'm not sure if all of these cases need an assertion on the message, but we might want an assertion on the cause. I'll update these tests to use ExpectedException.
> On May 2, 2016, 11:38 p.m., Jason Huynh wrote:
> > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceRemoteRRDUnitTest.java, line 18
> > <https://reviews.apache.org/r/46917/diff/1/?file=1369322#file1369322line18>
> >
> > Should this be proxy RR instead of remote RR?
> >
> > Is this a client or a peer proxy?
PeerProxy. I'll rename the test.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46917/#review131417
-----------------------------------------------------------
On May 2, 2016, 10:57 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46917/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 10:57 p.m.)
>
>
> Review request for geode, anilkumar gingade and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Testing how functions propagate exceptions from within the function to
> the caller or the result collector.
>
> Fixing a bug in exception propegation discovered while writing these tests.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java 57b1e71e8a5591e74f11041c916ed5cec1a8fd29
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceBase.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceLocalPRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceLocalRRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceMultipleOnMemberDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceRemotePRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceRemoteRRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceSingleOnMemberDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46917/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 46917: GEODE-625: Adding tests for exception
handling of functions
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46917/#review131417
-----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceBase.java (line 65)
<https://reviews.apache.org/r/46917/#comment195384>
Do we care about the message in the functionexception?
If so, instead of using the expected = FunctionException.class annotation, we can do:
//class variable
public ExpectedException expectedException = ExpectedException.none();
//in each test
expectedException.expect(SomeException.class);
expectedException.expectMessage("Some message");
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceRemoteRRDUnitTest.java (line 18)
<https://reviews.apache.org/r/46917/#comment195388>
Should this be proxy RR instead of remote RR?
Is this a client or a peer proxy?
- Jason Huynh
On May 2, 2016, 10:57 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46917/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 10:57 p.m.)
>
>
> Review request for geode, anilkumar gingade and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Testing how functions propagate exceptions from within the function to
> the caller or the result collector.
>
> Fixing a bug in exception propegation discovered while writing these tests.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDataStore.java 57b1e71e8a5591e74f11041c916ed5cec1a8fd29
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceBase.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceLocalPRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceLocalRRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceMultipleOnMemberDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceRemotePRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceRemoteRRDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceSingleOnMemberDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46917/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>