You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "andytaylor (via GitHub)" <gi...@apache.org> on 2024/01/08 12:50:03 UTC
[PR] ARTEMIS-4557 expose producer window size in clusterconnection JMX [activemq-artemis]
andytaylor opened a new pull request, #4732:
URL: https://github.com/apache/activemq-artemis/pull/4732
https://issues.apache.org/jira/browse/ARTEMIS-4557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4557 expose producer window size in clusterconnection JMX [activemq-artemis]
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on code in PR #4732:
URL: https://github.com/apache/activemq-artemis/pull/4732#discussion_r1446387049
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ClusterConnectionControlImpl.java:
##########
@@ -321,5 +321,18 @@ public Map<String, Object> getBridgeMetrics(String nodeId) {
}
+ @Override
+ public long getProducerWindowSize() {
+ if (AuditLogger.isBaseLoggingEnabled()) {
+ AuditLogger.getTopology(this.clusterConnection);
Review Comment:
This seems wrong, surely getProducerWindowSize() shouldn't be audit logging about getting topology?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4557 expose producer window size in clusterconnection JMX [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #4732:
URL: https://github.com/apache/activemq-artemis/pull/4732#discussion_r1447517406
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ClusterConnectionControlImpl.java:
##########
@@ -321,5 +321,18 @@ public Map<String, Object> getBridgeMetrics(String nodeId) {
}
+ @Override
+ public long getProducerWindowSize() {
+ if (AuditLogger.isBaseLoggingEnabled()) {
+ AuditLogger.getTopology(this.clusterConnection);
Review Comment:
Nice catch. I skimmed right over that. I fixed it with 42ddf99ca8846218ee7b49d97a4f5087318c15e3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4557 expose producer window size in clusterconnection JMX [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram merged PR #4732:
URL: https://github.com/apache/activemq-artemis/pull/4732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org