You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by tomaszguzialek <gi...@git.apache.org> on 2015/10/20 11:45:01 UTC
[GitHub] metamodel pull request: Maven-assembly-plugin in MetaModel-full.
GitHub user tomaszguzialek opened a pull request:
https://github.com/apache/metamodel/pull/60
Maven-assembly-plugin in MetaModel-full.
During "package" phase it creates the distributable version in target folder of the MetaModel-full module.
Fixes METAMODEL-144
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tomaszguzialek/metamodel METAMODEL-144-full
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/60.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #60
----
commit 5fb24c170e4d36d8de2473286d35e836a3359534
Author: tomaszguzialek <to...@humaninference.com>
Date: 2015-10-20T09:01:06Z
Maven-assembly-plugin in MetaModel-full.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Maven-assembly-plugin in MetaModel-full.
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/60#issuecomment-149824922
Looks very nice now. I'll do a quick run locally to verify the zip file's contents. And then merge :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Maven-assembly-plugin in MetaModel-full.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/60
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Maven-assembly-plugin in MetaModel-full.
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/60#issuecomment-149536285
This looks quite alright, except I am a bit wondering about two ugly things in the diff:
* The license header in pom.xml files is screwed.
* The log4j.xml file seems to have changed everywhere, but I cannot see any different. Newlines?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Maven-assembly-plugin in MetaModel-full.
Posted by tomaszguzialek <gi...@git.apache.org>.
Github user tomaszguzialek commented on the pull request:
https://github.com/apache/metamodel/pull/60#issuecomment-149510367
The build failed because of Cassandra cluster not starting within timeout, so unrelated issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---