You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Attila Kreiner (Code Review)" <ge...@cloudera.org> on 2022/11/15 16:44:49 UTC

[Impala-ASF-CR] IMPALA-11726 Make impala-shell work with kerberos authentication

Attila Kreiner has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19248


Change subject: IMPALA-11726 Make impala-shell work with kerberos authentication
......................................................................

IMPALA-11726 Make impala-shell work with kerberos authentication

This change does two things for the Kerberos authentication support for
impala-shell:

1) Makes external kerberos authentication optional in the docker
entrypoint script.

2) Removes the restriction that prevents to use LDAP group/user search
filters when kerberos authentication is enabled, so both kerberos and
LDAP can work with impala-shell.

Change-Id: I676f8f3d792690c3564e92a3fb37f151c31e1efd
---
M be/src/util/ldap-util.cc
M docker/daemon_entrypoint.sh
2 files changed, 18 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/19248/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I676f8f3d792690c3564e92a3fb37f151c31e1efd
Gerrit-Change-Number: 19248
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Kreiner <kr...@gmail.com>

[Impala-ASF-CR] IMPALA-11726 Make impala-shell work with kerberos authentication

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19248 )

Change subject: IMPALA-11726 Make impala-shell work with kerberos authentication
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11853/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676f8f3d792690c3564e92a3fb37f151c31e1efd
Gerrit-Change-Number: 19248
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Kreiner <kr...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Nov 2022 17:04:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11726 Make impala-shell work with kerberos authentication

Posted by "Attila Kreiner (Code Review)" <ge...@cloudera.org>.
Attila Kreiner has abandoned this change. ( http://gerrit.cloudera.org:8080/19248 )

Change subject: IMPALA-11726 Make impala-shell work with kerberos authentication
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/19248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I676f8f3d792690c3564e92a3fb37f151c31e1efd
Gerrit-Change-Number: 19248
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Kreiner <kr...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-11726 Make impala-shell work with kerberos authentication

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19248 )

Change subject: IMPALA-11726 Make impala-shell work with kerberos authentication
......................................................................


Patch Set 3:

(3 comments)

Quick comments

http://gerrit.cloudera.org:8080/#/c/19248/3/docker/daemon_entrypoint.sh
File docker/daemon_entrypoint.sh:

http://gerrit.cloudera.org:8080/#/c/19248/3/docker/daemon_entrypoint.sh@169
PS3, Line 169: # ======================= Interim Kerberos support for DWX ===========================
Maybe say what you are assuming rather than mentioning DWX which is not open source.


http://gerrit.cloudera.org:8080/#/c/19248/3/docker/daemon_entrypoint.sh@176
PS3, Line 176: EXTRA_ARGS=()
What is EXTRA_ARGS here? How is it used?


http://gerrit.cloudera.org:8080/#/c/19248/3/docker/daemon_entrypoint.sh@180
PS3, Line 180:   EXTRA_ARGS+=("-keytab_file=${SERVICE_KEYTAB}" "-principal=${SERVICE_PRINCIPAL}")
These look weird, why aren't they --principal and --keytab-file?



-- 
To view, visit http://gerrit.cloudera.org:8080/19248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676f8f3d792690c3564e92a3fb37f151c31e1efd
Gerrit-Change-Number: 19248
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Kreiner <kr...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Nov 2022 17:19:03 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11726 Make impala-shell work with kerberos authentication

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19248 )

Change subject: IMPALA-11726 Make impala-shell work with kerberos authentication
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19248/3/be/src/util/ldap-util.cc
File be/src/util/ldap-util.cc:

http://gerrit.cloudera.org:8080/#/c/19248/3/be/src/util/ldap-util.cc@a113
PS3, Line 113: 
Please describe what you've done to verify this works in the commit message. It was previously disabled because we had no way to test it.



-- 
To view, visit http://gerrit.cloudera.org:8080/19248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676f8f3d792690c3564e92a3fb37f151c31e1efd
Gerrit-Change-Number: 19248
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Kreiner <kr...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Nov 2022 16:48:46 +0000
Gerrit-HasComments: Yes