You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Liu Cong (JIRA)" <ji...@apache.org> on 2009/06/08 09:48:07 UTC
[jira] Created: (CXF-2265) JMS Test Suite.
JMS Test Suite.
---------------
Key: CXF-2265
URL: https://issues.apache.org/jira/browse/CXF-2265
Project: CXF
Issue Type: Sub-task
Reporter: Liu Cong
JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-2265) JMS Test Suite.
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liu Cong updated CXF-2265:
--------------------------
Attachment: test-patch2.txt
A new patch updating.
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Attachments: test-patch.txt, test-patch2.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CXF-2265) JMS Test Suite.
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liu Cong resolved CXF-2265.
---------------------------
Resolution: Fixed
The jms test suite have been finished, and the almost all the tests in the test suite passed.
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Assignee: Willem Jiang
> Attachments: new-test-patch.txt, new-test-patch2.txt, test-patch.txt, test-patch2.txt, test-patch3.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CXF-2265) JMS Test Suite.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CXF-2265:
---------------------------------
Assignee: Willem Jiang
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Assignee: Willem Jiang
> Attachments: test-patch.txt, test-patch2.txt, test-patch3.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-2265) JMS Test Suite.
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liu Cong updated CXF-2265:
--------------------------
Attachment: new-test-patch.txt
1. The last tests for test suite are added. (http://dev.w3.org/2008/ws/soapjms/testcases/)
2. Modify some errors according to SOAP JMS specification about SOAP Fault. Now they passed the test suite.
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Assignee: Willem Jiang
> Attachments: new-test-patch.txt, test-patch.txt, test-patch2.txt, test-patch3.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-2265) JMS Test Suite.
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liu Cong updated CXF-2265:
--------------------------
Attachment: test-patch.txt
A test suite test patch.
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Reporter: Liu Cong
> Attachments: test-patch.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-2265) JMS Test Suite.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742155#action_12742155 ]
Willem Jiang commented on CXF-2265:
-----------------------------------
@LiuCong,
I found you added the dependency of the jms transport to the soap binding pom. That is what we should avoid.
soap binding should know nothing about the transport level things.
If you want want to check the jms endpoint URI, you could get the URI information from the endpoint's addressInfo, then use a util tool to find the targetService.
Please fix it , then I'd like to apply your patch ;)
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Assignee: Willem Jiang
> Attachments: new-test-patch.txt, test-patch.txt, test-patch2.txt, test-patch3.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-2265) JMS Test Suite.
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liu Cong updated CXF-2265:
--------------------------
Attachment: new-test-patch2.txt
Thank you for your advice.
I just fix this issue.
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Assignee: Willem Jiang
> Attachments: new-test-patch.txt, new-test-patch2.txt, test-patch.txt, test-patch2.txt, test-patch3.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CXF-2265) JMS Test Suite.
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737030#action_12737030 ]
Liu Cong edited comment on CXF-2265 at 7/30/09 12:56 AM:
---------------------------------------------------------
A new test patch according to Willem's advice.
I use JMSTemplate.receive to replace the MessageListenerContainer.
This will create less threads.
https://issues.apache.org/jira/secure/attachment/12415002/test-patch3.txt
was (Author: liucong):
A new test patch according to Willem's advice.
I use JMSTemplate.receive to replace the MessageListenerContainer.
This will create less threads.
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Attachments: test-patch.txt, test-patch2.txt, test-patch3.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CXF-2265) JMS Test Suite.
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742172#action_12742172 ]
Liu Cong edited comment on CXF-2265 at 8/11/09 6:42 PM:
--------------------------------------------------------
Thank you for your advice.
I just fix this issue. (https://issues.apache.org/jira/secure/attachment/12416277/new-test-patch2.txt)
was (Author: liucong):
Thank you for your advice.
I just fix this issue.
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Assignee: Willem Jiang
> Attachments: new-test-patch.txt, new-test-patch2.txt, test-patch.txt, test-patch2.txt, test-patch3.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-2265) JMS Test Suite.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737070#action_12737070 ]
Willem Jiang commented on CXF-2265:
-----------------------------------
@ LiuCong,
You did a nice job.
I just committed your patch, add did a minor change of the comments and added mock test for the SOAPJMSTestSuit.
Since the test suit work is not done yet, I will keep this JIRA open until it is finished.
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Attachments: test-patch.txt, test-patch2.txt, test-patch3.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CXF-2265) JMS Test Suite.
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737030#action_12737030 ]
Liu Cong edited comment on CXF-2265 at 7/30/09 2:00 AM:
--------------------------------------------------------
A new test patch according to Willem's advice.
I use JMSTemplate.receive to replace the MessageListenerContainer.
This will create less threads.
https://issues.apache.org/jira/secure/attachment/12415002/test-patch3.txt
The list of changes is as follows:
(1) Some SOAPFault processing int cxf-rt-bindings-soap subproject.
(2) To generate the CorrelationID in the client of jms transport according to the following rules. And I change the systest for the correlationid according to this.
userCID -> userCID
userCID + conduitSelectorPrefix -> userCID
userCID + conduitSelectorPrefix + useConduitIdSelector(true) -> userCID
userCID + conduitSelectorPrefix + useConduitIdSelector(false) -> userCID
conduitSelectorPrefix + useConduitIdSelector(true) ->
conduitSelectorPrefix + conduitId + index
conduitSelectorPrefix + useConduitIdSelector(false) ->
conduitSelectorPrefix + index
useConduitIdSelector(true) -> conduitId + index
useConduitIdSelector(false) -> the request message's messageID
->'s left side is the condition.
->'s right side is rule for generation of CorrelationID.
userCID means that the client gives a CorrelationID.
conduitSelectorPrefix means that the client configures in the wsdl.
useConduitIdSelector means that the client configures in the wsdl.
conduitId means that the string generated by the jms-tranport's JMSConduit.
index is a autoincreasing number which indicates the uniqueness of the
CorrelationID.
(3) Remove JMSListener, and use JMSTemplate.receive method to deal with the response message.
(4) Some small changes about JMSMessage's properties which is not right for specification.
(5) Add test suite tests(http://dev.w3.org/2008/ws/soapjms/testcases/)(0001-1001). And build the framework for test suite tests.
was (Author: liucong):
A new test patch according to Willem's advice.
I use JMSTemplate.receive to replace the MessageListenerContainer.
This will create less threads.
https://issues.apache.org/jira/secure/attachment/12415002/test-patch3.txt
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Attachments: test-patch.txt, test-patch2.txt, test-patch3.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CXF-2265) JMS Test Suite.
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736486#action_12736486 ]
Liu Cong edited comment on CXF-2265 at 7/29/09 12:27 AM:
---------------------------------------------------------
A new patch updating.
https://issues.apache.org/jira/secure/attachment/12414856/test-patch2.txt
was (Author: liucong):
A new patch updating.
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Attachments: test-patch.txt, test-patch2.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-2265) JMS Test Suite.
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liu Cong updated CXF-2265:
--------------------------
Attachment: test-patch3.txt
A new test patch according to Willem's advice.
I use JMSTemplate.receive to replace the MessageListenerContainer.
This will create less threads.
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Attachments: test-patch.txt, test-patch2.txt, test-patch3.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CXF-2265) JMS Test Suite.
Posted by "Liu Cong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735384#action_12735384 ]
Liu Cong edited comment on CXF-2265 at 7/26/09 7:26 AM:
--------------------------------------------------------
A test suite test patch.
The list of changes is as follows:
(1) Some SOAPFault processing int cxf-rt-bindings-soap subproject.
(2) To generate the CorrelationID in the client of jms transport according to the following rules. And I change the systest for the correlationid according to this.
userCID -> userCID
userCID + conduitSelectorPrefix -> userCID
userCID + conduitSelectorPrefix + useConduitIdSelector(true) -> userCID
userCID + conduitSelectorPrefix + useConduitIdSelector(false) -> userCID
conduitSelectorPrefix + useConduitIdSelector(true) ->
conduitSelectorPrefix + conduitId + index
conduitSelectorPrefix + useConduitIdSelector(false) ->
conduitSelectorPrefix + index
useConduitIdSelector(true) -> conduitId + index
useConduitIdSelector(false) -> the request message's messageID
->'s left side is the condition.
->'s right side is rule for generation of CorrelationID.
userCID means that the client gives a CorrelationID.
conduitSelectorPrefix means that the client configures in the wsdl.
useConduitIdSelector means that the client configures in the wsdl.
conduitId means that the string generated by the jms-tranport's JMSConduit.
index is a autoincreasing number which indicates the uniqueness of the
CorrelationID.
(3) The JMSListener of the response message.
(4) Some small changes about JMSMessage's properties which is not right for specification.
(5) Add test suite tests(http://dev.w3.org/2008/ws/soapjms/testcases/)(0001-1001). And build the framework for test suite tests.
was (Author: liucong):
A test suite test patch.
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Reporter: Liu Cong
> Attachments: test-patch.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-2265) JMS Test Suite.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736969#action_12736969 ]
Willem Jiang commented on CXF-2265:
-----------------------------------
Hi,
I reviewed you patch, and found there is a performance issue for your current MessageID pattern implementation.
You create the a DefaultMessageListenerContainer per request, as you know the DefaultMessageListenerContainer has a thread pool to listen to the reply queue.
Since the MessageID is unique, you will create thousands of MessageListenerContainer if you send out thousands of request, and I don't find the code of releasing the MessageListenerContainer. It can work for massive message sending.
I think it is OK for the Correlation ID pattern to use the MessageListenerContainer , since it can use the CorrelationPerfix to filter the response message, and it is create per response queue.
To resolved the performance issue, you have two way to do , one is create the MessageListenerContainer per reply destination ( It will not work for the temp queue), and using the correlation id map for response message. The other is using the Spring template to send and receive the synchronized message (which is a good way to handle the response time out issue). You can find some example in camel-jms component's CamelTemplate.
BTW , there is small issue of jms.xsd change. I don't think change the jms.xsd about the jms conduit's CoduitSelectorPrefix's default value is right , since it is optional, the default value is meaningless.
Willem
> JMS Test Suite.
> ---------------
>
> Key: CXF-2265
> URL: https://issues.apache.org/jira/browse/CXF-2265
> Project: CXF
> Issue Type: Sub-task
> Components: Soap Binding
> Reporter: Liu Cong
> Attachments: test-patch.txt, test-patch2.txt
>
>
> JMS Test suite ([WWW] http://dev.w3.org/2008/ws/soapjms/testcases/) .
> We will finish an integration test for SOAP over JMS in this sub-task and make it pass the JMS Test Suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.