You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by "Alexey N. Solofnenko" <A....@mdl.com> on 2006/04/27 02:06:55 UTC
Why parser handlers in ProjectHelper2 private?
Hello,
Making them private precludes from changing just one of them. Are
there any objections to make them public (or to add trivial set/get
methods)?
- Alexey.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
RE: Why parser handlers in ProjectHelper2 private?
Posted by Steve <mc...@apache.org>.
> -----Original Message-----
> From: Alexey Solofnenko [mailto:trelony@gmail.com]
> Sent: Sunday, 30 April 2006 2:04 AM
> To: Ant Developers List
> Subject: Re: Why parser handlers in ProjectHelper2 private?
>
> Do you prefer protected setters or protected fields?
Just a general comment - protected setters are much more preferrable than
protected fields.
/Steve.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Why parser handlers in ProjectHelper2 private?
Posted by Stefan Bodewig <bo...@apache.org>.
On Sat, 29 Apr 2006, Alexey Solofnenko <tr...@gmail.com> wrote:
> Do you prefer protected setters or protected fields?
I prefer immutable classes if possible 8-)
In this case I prefer setters over non-private fields.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Why parser handlers in ProjectHelper2 private?
Posted by Alexey Solofnenko <tr...@gmail.com>.
Do you prefer protected setters or protected fields?
- Alexey.
On 4/29/06, Stefan Bodewig <bo...@apache.org> wrote:
>
> On Sat, 29 Apr 2006, Alexey Solofnenko <tr...@gmail.com> wrote:
>
> > Yes, I am thinking about inheriting from ProjectHelper2 and
> > replacing target handler.
>
> So protected setters would be enough, there wouldn't be any need to
> make them public.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
--
Alexey N. Solofnenko trelony at gmail.com
home: http://trelony.cjb.net/
Pleasant Hill, CA (GMT-8 hours usually)
Re: Why parser handlers in ProjectHelper2 private?
Posted by Stefan Bodewig <bo...@apache.org>.
On Sat, 29 Apr 2006, Alexey Solofnenko <tr...@gmail.com> wrote:
> Yes, I am thinking about inheriting from ProjectHelper2 and
> replacing target handler.
So protected setters would be enough, there wouldn't be any need to
make them public.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Why parser handlers in ProjectHelper2 private?
Posted by Alexey Solofnenko <tr...@gmail.com>.
Yes, I am thinking about inheriting from ProjectHelper2 and replacing target
handler.
- Alexey.
On 4/29/06, Stefan Bodewig <bo...@apache.org> wrote:
>
> On Thu, 27 Apr 2006, Alexey Solofnenko <al...@apache.org> wrote:
>
> > I want to change target parser to process and store extra target
> > attributes [without changing main ANT]. Replacing just target
> > handler would be the easiest solution.
>
> And how do you intend to do that? Provide your own ProjectHelper that
> is a subclass of ProjectHelper2?
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
--
Alexey N. Solofnenko trelony at gmail.com
home: http://trelony.cjb.net/
Pleasant Hill, CA (GMT-8 hours usually)
Re: Why parser handlers in ProjectHelper2 private?
Posted by Stefan Bodewig <bo...@apache.org>.
On Thu, 27 Apr 2006, Alexey Solofnenko <al...@apache.org> wrote:
> I want to change target parser to process and store extra target
> attributes [without changing main ANT]. Replacing just target
> handler would be the easiest solution.
And how do you intend to do that? Provide your own ProjectHelper that
is a subclass of ProjectHelper2?
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Why parser handlers in ProjectHelper2 private?
Posted by Alexey Solofnenko <al...@apache.org>.
I want to change target parser to process and store extra target attributes
[without changing main ANT]. Replacing just target handler would be the
easiest solution.
- Alexey.
On 4/27/06, Stefan Bodewig <bo...@apache.org> wrote:
>
> On Wed, 26 Apr 2006, Alexey N. Solofnenko <A....@mdl.com>
> wrote:
>
> > Making them private precludes from changing just one of them. Are
> > there any objections to make them public (or to add trivial
> > set/get methods)?
>
> Can you explain why you'd want to change them? What is the context?
>
> Stefan
>
>
--
Alexey N. Solofnenko trelony at gmail.com
home: http://trelony.cjb.net/
Pleasant Hill, CA (GMT-8 hours usually)
Re: Why parser handlers in ProjectHelper2 private?
Posted by Stefan Bodewig <bo...@apache.org>.
On Wed, 26 Apr 2006, Alexey N. Solofnenko <A....@mdl.com>
wrote:
> Making them private precludes from changing just one of them. Are
> there any objections to make them public (or to add trivial
> set/get methods)?
Can you explain why you'd want to change them? What is the context?
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org