[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #694: [#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics

["jerqi (via GitHub)" <gi...@apache.org>]

jerqi commented on code in PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#discussion_r1130395415


##########
coordinator/src/test/java/org/apache/uniffle/coordinator/metric/CoordinatorMetricsTest.java:
##########
@@ -89,7 +89,14 @@ public void testCoordinatorMetrics() throws Exception {
     ObjectMapper mapper = new ObjectMapper();
     JsonNode actualObj = mapper.readTree(content);
     assertEquals(2, actualObj.size());
-    assertEquals(10, actualObj.get("metrics").size());
+    int actualMetrics = 0;
+    for (JsonNode metrics : actualObj.get("metrics")) {
+      if (CoordinatorMetrics.APP_NUM_TO_USER.equals(metrics.get("name").textValue())) {

Review Comment:
   @smallzhongfeng tried, but it doesn't matter. This test is so flaky that we should fix this issue asap. So we use the simplest to fix first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org