You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/02/21 12:07:56 UTC
Review Request 56879: RANGER-1402 - NPE if there is a problem with the
HiveClient driverClassName
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56879/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1402
https://issues.apache.org/jira/browse/RANGER-1402
Repository: ranger
Description
-------
There is a NPE if there is a problem with the HiveClient driverClassName. This is because the code is trying to put a "null" HiveClient instance into a ConcurrentMap.
Diffs
-----
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveConnectionMgr.java b36d5da
Diff: https://reviews.apache.org/r/56879/diff/
Testing
-------
Tested that no NPE appears in the logs after the fix.
Thanks,
Colm O hEigeartaigh
Re: Review Request 56879: RANGER-1402 - NPE if there is a problem
with the HiveClient driverClassName
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56879/#review168700
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On \u4e8c\u6708 21, 2017, 12:07 p.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56879/
> -----------------------------------------------------------
>
> (Updated \u4e8c\u6708 21, 2017, 12:07 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1402
> https://issues.apache.org/jira/browse/RANGER-1402
>
>
> Repository: ranger
>
>
> Description
> -------
>
> There is a NPE if there is a problem with the HiveClient driverClassName. This is because the code is trying to put a "null" HiveClient instance into a ConcurrentMap.
>
>
> Diffs
> -----
>
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveConnectionMgr.java b36d5da
>
>
> Diff: https://reviews.apache.org/r/56879/diff/1/
>
>
> Testing
> -------
>
> Tested that no NPE appears in the logs after the fix.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>