You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/09 18:26:07 UTC
[kudu-CR] python: check status result when setting row contents
Hello Jordan Birdsell,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5018
to review the following change.
Change subject: python: check status result when setting row contents
......................................................................
python: check status result when setting row contents
The various PartialRow::Set*() functions return a Status to indicate an
error if an incorrect type is passed or when trying to set a NULL value
on a non-NULL column. We previously weren't checking these Status
results in the Python client.
Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 13 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/5018/1
--
To view, visit http://gerrit.cloudera.org:8080/5018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
[kudu-CR] python: check status result when setting row contents
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: python: check status result when setting row contents
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] python: check status result when setting row contents
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: python: check status result when setting row contents
......................................................................
Patch Set 2:
This need rebased?
--
To view, visit http://gerrit.cloudera.org:8080/5018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] python: check status result when setting row contents
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: python: check status result when setting row contents
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5018/1/python/kudu/client.pyx
File python/kudu/client.pyx:
PS1, Line 2433: self.row.SetUnixTimeMicros(i, <int64_t>
: to_unixtime_micros(value))
Missed one.
--
To view, visit http://gerrit.cloudera.org:8080/5018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] python: check status result when setting row contents
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Jordan Birdsell, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5018
to look at the new patch set (#3).
Change subject: python: check status result when setting row contents
......................................................................
python: check status result when setting row contents
The various PartialRow::Set*() functions return a Status to indicate an
error if an incorrect type is passed or when trying to set a NULL value
on a non-NULL column. We previously weren't checking these Status
results in the Python client.
Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 16 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/5018/3
--
To view, visit http://gerrit.cloudera.org:8080/5018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] python: check status result when setting row contents
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: python: check status result when setting row contents
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] python: check status result when setting row contents
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5018
to look at the new patch set (#2).
Change subject: python: check status result when setting row contents
......................................................................
python: check status result when setting row contents
The various PartialRow::Set*() functions return a Status to indicate an
error if an incorrect type is passed or when trying to set a NULL value
on a non-NULL column. We previously weren't checking these Status
results in the Python client.
Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 15 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/5018/2
--
To view, visit http://gerrit.cloudera.org:8080/5018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] python: check status result when setting row contents
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has submitted this change and it was merged.
Change subject: python: check status result when setting row contents
......................................................................
python: check status result when setting row contents
The various PartialRow::Set*() functions return a Status to indicate an
error if an incorrect type is passed or when trying to set a NULL value
on a non-NULL column. We previously weren't checking these Status
results in the Python client.
Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
Reviewed-on: http://gerrit.cloudera.org:8080/5018
Tested-by: Kudu Jenkins
Reviewed-by: Jordan Birdsell <jt...@apache.org>
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 16 insertions(+), 12 deletions(-)
Approvals:
Jordan Birdsell: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47be624de49d26de7a5c0b3af320e0bc907d70ad
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins