You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/09/22 03:07:44 UTC
[kudu-CR] ensure every gflag is defined outside of a namespace
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4505
to review the following change.
Change subject: ensure every gflag is defined outside of a namespace
......................................................................
ensure every gflag is defined outside of a namespace
The gflags docs recommend that all gflags be defined globally, outside of any
namespace. This patch moves a couple gflags out of their respective namespaces
accordingly. It shouldn't be backwards incompatible in any way.
Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
---
M src/kudu/master/master_options.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/server/server_base_options.cc
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tserver/tablet_server_options.cc
M src/kudu/util/memory/memory.cc
M src/kudu/util/striped64-test.cc
10 files changed, 60 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/4505/1
--
To view, visit http://gerrit.cloudera.org:8080/4505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] ensure every gflag is defined outside of a namespace
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: ensure every gflag is defined outside of a namespace
......................................................................
Patch Set 3: Verified+1
Overriding Jenkins, flaky ITClient test.
Also ignoring Tidy Bot's last comment since it's to existing code that I didn't modify, and I'm tired of playing catch up with it.
--
To view, visit http://gerrit.cloudera.org:8080/4505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] ensure every gflag is defined outside of a namespace
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: ensure every gflag is defined outside of a namespace
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] ensure every gflag is defined outside of a namespace
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: ensure every gflag is defined outside of a namespace
......................................................................
ensure every gflag is defined outside of a namespace
The gflags docs recommend that all gflags be defined globally, outside of any
namespace. This patch moves a couple gflags out of their respective namespaces
accordingly. It shouldn't be backwards incompatible in any way.
Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
Reviewed-on: http://gerrit.cloudera.org:8080/4505
Reviewed-by: Dan Burkert <da...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/master/master_options.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/server/server_base_options.cc
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tserver/tablet_server_options.cc
M src/kudu/util/flag_tags.h
M src/kudu/util/memory/memory.cc
M src/kudu/util/striped64-test.cc
11 files changed, 67 insertions(+), 73 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] ensure every gflag is defined outside of a namespace
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4505
to look at the new patch set (#3).
Change subject: ensure every gflag is defined outside of a namespace
......................................................................
ensure every gflag is defined outside of a namespace
The gflags docs recommend that all gflags be defined globally, outside of any
namespace. This patch moves a couple gflags out of their respective namespaces
accordingly. It shouldn't be backwards incompatible in any way.
Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
---
M src/kudu/master/master_options.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/server/server_base_options.cc
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tserver/tablet_server_options.cc
M src/kudu/util/flag_tags.h
M src/kudu/util/memory/memory.cc
M src/kudu/util/striped64-test.cc
11 files changed, 67 insertions(+), 73 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/4505/3
--
To view, visit http://gerrit.cloudera.org:8080/4505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] ensure every gflag is defined outside of a namespace
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4505
to look at the new patch set (#2).
Change subject: ensure every gflag is defined outside of a namespace
......................................................................
ensure every gflag is defined outside of a namespace
The gflags docs recommend that all gflags be defined globally, outside of any
namespace. This patch moves a couple gflags out of their respective namespaces
accordingly. It shouldn't be backwards incompatible in any way.
Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
---
M src/kudu/master/master_options.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/server/server_base_options.cc
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tserver/tablet_server_options.cc
M src/kudu/util/flag_tags.h
M src/kudu/util/memory/memory.cc
M src/kudu/util/striped64-test.cc
11 files changed, 60 insertions(+), 65 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/4505/2
--
To view, visit http://gerrit.cloudera.org:8080/4505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] ensure every gflag is defined outside of a namespace
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: ensure every gflag is defined outside of a namespace
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
lgtm, not sure what the jenkins failure's about
http://gerrit.cloudera.org:8080/#/c/4505/1/src/kudu/master/master_options.cc
File src/kudu/master/master_options.cc:
Line 30: TAG_FLAG(master_addresses, stable);
> warning: sizeof() doesn't return the size of the container; did you mean .s
I guess we need a different trick to double check that FLAGS_##flag_name is defined. maybe sizeof(decltype(...)) would work
--
To view, visit http://gerrit.cloudera.org:8080/4505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes