You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2020/01/10 09:54:39 UTC

[skywalking] branch percentile updated: Fix wrong column.

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch percentile
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/percentile by this push:
     new 898cefa  Fix wrong column.
898cefa is described below

commit 898cefacd9dab058c392096fd4cfeacb37f68f82
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Fri Jan 10 17:54:14 2020 +0800

    Fix wrong column.
---
 .../oap/server/core/analysis/metrics/PercentileMetrics.java          | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/PercentileMetrics.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/PercentileMetrics.java
index 9e59f7f..976d21a 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/PercentileMetrics.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/PercentileMetrics.java
@@ -42,13 +42,14 @@ public abstract class PercentileMetrics extends GroupMetrics implements MultiInt
 
     private static final int[] RANKS = {50, 75, 90, 95, 99};
 
-    @Getter @Setter @Column(columnName = VALUE) private int[] values = {0, 0, 0, 0, 0};
+    @Getter @Setter @Column(columnName = VALUE, isValue = true) private IntKeyLongValueHashMap percentileValues;
     @Getter @Setter @Column(columnName = PRECISION) private int precision;
     @Getter @Setter @Column(columnName = DETAIL_GROUP) private IntKeyLongValueHashMap detailGroup;
 
     private boolean isCalculated;
 
     public PercentileMetrics() {
+        percentileValues = new IntKeyLongValueHashMap(5);
         detailGroup = new IntKeyLongValueHashMap(30);
     }
 
@@ -93,7 +94,7 @@ public abstract class PercentileMetrics extends GroupMetrics implements MultiInt
                 for (IntKeyLongValue element : sortedData) {
                     count += element.getValue();
                     if (count >= roof) {
-                        values[i] = element.getKey() * precision;
+                        percentileValues.put(i, new IntKeyLongValue(i, element.getKey() * precision));
                         return;
                     }
                 }