[GitHub] [accumulo] milleruntime commented on pull request #2457: Refactor AuthenticationTokenIdentifier & DelegationTokenImpl

[GitBox <gi...@apache.org>]

milleruntime commented on pull request #2457:
URL: https://github.com/apache/accumulo/pull/2457#issuecomment-1029859473


   > However, I wasn't able to determine from these changes what the actual bug was that you were trying to fix. This seemed mostly about cleaning up some complexity, and less about fixing a bug. Which part fixed the bug you saw?
   
   These changes came from testing of #2451. One of the tests was failing due to instance Id being null. https://github.com/apache/accumulo/runs/5036934940?check_suite_focus=true I think it was a minor bug since it doesn't really seem like it was used for anything other than setting the name of the token. But it was hard to tell in the code so I ended up cleaning up the code just to be sure.
   
   Since I am not sure how long that test job will stick around, here is the test failure from #2451:
   <pre>
   [ERROR] Errors: 
   [ERROR]   SaslDigestCallbackHandlerTest.testTokenAndIdentifierSerialization:115 » NullPointer
   [ERROR]   SaslDigestCallbackHandlerTest.testTokenSerialization:99 » NullPointer Instance...
   </pre>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org