You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/12 18:31:37 UTC
[GitHub] [arrow] zeroshade opened a new pull request #8175: [WIP] ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
zeroshade opened a new pull request #8175:
URL: https://github.com/apache/arrow/pull/8175
Built out from https://github.com/apache/arrow/pull/6731 with some inspiration from the existing Reader/Writer and the C++ Flight implementation. Still need to build out the tests some more, but would like to get opinions and thoughts on what I've got so far as I continue to build it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-695894267
Bump. Can someone please give this a review so we can get this merged? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-691602646
Tagging the people that were on the previous PR for visibility:
@sbinet @mindhash @stuartcarnie could any / all of you have a look / review? Thanks much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] stuartcarnie commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
stuartcarnie commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698748217
Yes, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8175: [WIP] ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-691527891
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sbinet commented on a change in pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
sbinet commented on a change in pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#discussion_r491881927
##########
File path: go/arrow/flight/client.go
##########
@@ -0,0 +1,89 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package flight
+
+import (
+ context "context"
Review comment:
what about just:
```suggestion
"context"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] stuartcarnie commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
stuartcarnie commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698748217
Yes, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698560159
@wesm @sbinet @stuartcarnie @mindhash bump
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a change in pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
zeroshade commented on a change in pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#discussion_r492737156
##########
File path: go/arrow/flight/client.go
##########
@@ -0,0 +1,89 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package flight
+
+import (
+ context "context"
Review comment:
i don't know why my IDE did that -_- i'll fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698560159
@wesm @sbinet @stuartcarnie @mindhash bump
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sbinet commented on a change in pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
sbinet commented on a change in pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#discussion_r491881927
##########
File path: go/arrow/flight/client.go
##########
@@ -0,0 +1,89 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package flight
+
+import (
+ context "context"
Review comment:
what about just:
```suggestion
"context"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698922798
```
apache-rat license violation: go/arrow/flight/Flight_grpc.pb.go
apache-rat license violation: go/arrow/flight/example_flight_server_test.go
```
These files should have been added to the `rat_exclude_files.txt`.
Just put up a pr https://github.com/apache/arrow/pull/8273
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-695894267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-696254425
Agree it would be good for this to be reviewed / merged. Can you rebase and get a more complete CI build?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-696370510
@wesm as far as i can tell the two checks that are failing are unrelated to this PR.
I have ideas for further exploring / adding more functionality for the FlightRPC stuff, but I don't want to put too much into this PR and would rather further development be a separate PR to reach more feature parity with the C++ / Python versions of the flight server/client. I'm actually currently building out a project at work that will be utilizing the Go flight rpc server and client which was the impetus for me building this out. So anything you can do to help get this reviewed and pushed along would be greatly appreciated.
Thanks much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #8175:
URL: https://github.com/apache/arrow/pull/8175
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a change in pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
zeroshade commented on a change in pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#discussion_r492737156
##########
File path: go/arrow/flight/client.go
##########
@@ -0,0 +1,89 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package flight
+
+import (
+ context "context"
Review comment:
i don't know why my IDE did that -_- i'll fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8175: [WIP] ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-691527891
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-691529751
https://issues.apache.org/jira/browse/ARROW-8601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-696370510
@wesm as far as i can tell the two checks that are failing are unrelated to this PR.
I have ideas for further exploring / adding more functionality for the FlightRPC stuff, but I don't want to put too much into this PR and would rather further development be a separate PR to reach more feature parity with the C++ / Python versions of the flight server/client. I'm actually currently building out a project at work that will be utilizing the Go flight rpc server and client which was the impetus for me building this out. So anything you can do to help get this reviewed and pushed along would be greatly appreciated.
Thanks much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8175: [WIP] ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-691527891
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-696254425
Agree it would be good for this to be reviewed / merged. Can you rebase and get a more complete CI build?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8175: [WIP] ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-691527891
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-696263817
@wesm rebased
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #8175:
URL: https://github.com/apache/arrow/pull/8175
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698922798
```
apache-rat license violation: go/arrow/flight/Flight_grpc.pb.go
apache-rat license violation: go/arrow/flight/example_flight_server_test.go
```
These files should have been added to the `rat_exclude_files.txt`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org