[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3145: [CARBONDATA-3315] Fix for Range Filter failing with two between clauses as children of OR expression

[GitBox <gi...@apache.org>]

qiuchenjian commented on a change in pull request #3145: [CARBONDATA-3315] Fix for Range Filter failing with two between clauses as children of OR expression
URL: https://github.com/apache/carbondata/pull/3145#discussion_r264946159
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/detailquery/RangeFilterTestCase.scala
 ##########
 @@ -587,7 +589,40 @@ class RangeFilterTestCase extends QueryTest with BeforeAndAfterAll {
       sql("select empname from NO_DICTIONARY_HIVE_8 where empname <= '107'"))
   }
 
+  test("Range filter with two between clauses") {
+    sql("drop table if exists carbontest")
+    sql(
+      "create table carbontest(c1 string, c2 string, c3 int) stored by 'carbondata' tblproperties" +
+      "('sort_columns'='c3')")
+    (0 to 10).foreach { index =>
+      sql(s"insert into carbontest select '$index','$index',$index")
+    }
 
 Review comment:
   Better to move the drop and create clause to “beforeAll“ and “afterAll”  to maintain unified code style 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services