[jira] [Commented] (ARTEMIS-3984) LegacyLDAPSecuritySettingPlugin shouldn't modify existing matches

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603809#comment-17603809 ] 

ASF subversion and git services commented on ARTEMIS-3984:
----------------------------------------------------------

Commit a9a85f98db4f49d633541069ae997b4d099837e3 in activemq-artemis's branch refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=a9a85f98db ]

ARTEMIS-3984 LegacyLDAPSecuritySettingPlugin shouldn't modify existing matches

When the LegacyLDAPSecuritySettingPlugin has enableListener set to true
and a new permission is added it will try to modify the existing match
if one exists. This is problematic if there's a more generic wildcard
match than the specific one that's modified.

This commit fixes that problem so that instead of modifying the existing
match(es) it simply adds a new one. The plugin never should have tried
modifying the existing match in the first place as two identical matches
would be a configuration error.


> LegacyLDAPSecuritySettingPlugin shouldn't modify existing matches
> -----------------------------------------------------------------
>
>                 Key: ARTEMIS-3984
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3984
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.25.0
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>             Fix For: 3.0.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> When the LegacyLDAPSecuritySettingPlugin has {{enableListener}} set to {{true}} and a new permission is added it will try to modify the existing match if one exists. This is problematic if there's a more generic wildcard match than the specific one that's modified.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)