You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/05/01 00:52:21 UTC
Review Request 20924: For remote database configuration,
ambari server script should not run DDL
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20924/
-----------------------------------------------------------
Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Jeff Sposetti.
Bugs: AMBARI-5644
https://issues.apache.org/jira/browse/AMBARI-5644
Repository: ambari
Description
-------
ambari-server.py runs the Create DDL script on a remote DB if it finds a client for the DB installed.
It should only run DDL on Embedded DB and not remote databases.
*Note*: Left execute_remote_script as a deprecated method, not sure if this should be deleted completely.
Diffs
-----
ambari-server/src/main/python/ambari-server.py 182bc38
ambari-server/src/test/python/TestAmbariServer.py be3c64a
Diff: https://reviews.apache.org/r/20924/diff/
Testing
-------
----------------------------------------------------------------------
Ran 202 tests in 0.632s
OK
----------------------------------------------------------------------
Total run:547
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle
Re: Review Request 20924: For remote database configuration,
ambari server script should not run DDL
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20924/#review41891
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On April 30, 2014, 10:52 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20924/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 10:52 p.m.)
>
>
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Jeff Sposetti.
>
>
> Bugs: AMBARI-5644
> https://issues.apache.org/jira/browse/AMBARI-5644
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ambari-server.py runs the Create DDL script on a remote DB if it finds a client for the DB installed.
>
> It should only run DDL on Embedded DB and not remote databases.
>
> *Note*: Left execute_remote_script as a deprecated method, not sure if this should be deleted completely.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 182bc38
> ambari-server/src/test/python/TestAmbariServer.py be3c64a
>
> Diff: https://reviews.apache.org/r/20924/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 202 tests in 0.632s
>
> OK
> ----------------------------------------------------------------------
> Total run:547
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Sid Wagle
>
>