You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by remibergsma <gi...@git.apache.org> on 2015/04/14 06:39:11 UTC
[GitHub] cloudstack pull request: KVM: improve CentOS 7 support (ifconfig)
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/165
KVM: improve CentOS 7 support (ifconfig)
CentOS 7 does not ship with ifconfig anymore. We should use ip commands instead. This also works on older versions, like CentOS 6 and Ubuntu 12.x/14.x, that we support.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/remibergsma/cloudstack centos7_ifconfig_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #165
----
commit 232f5b0d5a2739ffd428d049050e09d3c0bc400a
Author: Remi Bergsma <gi...@remi.nl>
Date: 2015-04-14T03:45:15Z
KVM: improve CentOS 7 support
CentOS 7 does not ship with ifconfig anymore. We should use ip commands instead. This also works on older versions, like CentOS 6 and Ubuntu 12.x/14.x, that we support.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: improve CentOS 7 support (ifconfig)
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/165#issuecomment-92789451
@NuxRo @remibergsma in that case should we merge this patch on 4.5 as well? I tested this with 4.5 advance zone with Ubuntu 14.04 host and it worked for me, though I did not do exhaustive set of tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: improve CentOS 7 support (ifconfig)
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/165#issuecomment-92713667
@remibergsma thanks for the patch will test and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: improve CentOS 7 support (ifconfig)
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: improve CentOS 7 support (ifconfig)
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/165#issuecomment-92988843
@bhaisaab we even want this in 4.4 @SBP as we are experimenting with KVM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: improve CentOS 7 support (ifconfig)
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/165#issuecomment-92774873
@remibergsma why not add the dependency to install "net-tools" to rpms? I've tested the patch with 4.5, it worked for me. but applying only on master now. Please advise if I should apply on 4.5 as well, I've added net-tools dependency in case of 4.5 so on centos7 net-tools will bring in ifconfig on kvm hosts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: KVM: improve CentOS 7 support (ifconfig)
Posted by NuxRo <gi...@git.apache.org>.
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/165#issuecomment-92782014
Do note there are slight differences between EL7 ifconfig output and EL6.
Since we're making changes, +1 for "ip", ifconfig might not even be available at all in the next releases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---