You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2021/10/18 09:02:24 UTC
[GitHub] [groovy] suoyi123wang opened a new pull request #1643: fix ArrayIndexOutOfBoundsException
suoyi123wang opened a new pull request #1643:
URL: https://github.com/apache/groovy/pull/1643
in this method org.codehaus.groovy.tools.GrapeUtil.getIvyParts, when running the testcase in below,it will fail for ArrayIndexOutOfBoundsException
[
](url)
I think you should either declare the legal format of the parameters, or judge the length of the array parts in the code in advance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1643: fix ArrayIndexOutOfBoundsException
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1643:
URL: https://github.com/apache/groovy/pull/1643#issuecomment-946242209
Hi, this change looks good. Would you be able to create a test? I would suggest creating a new `org.codehaus.groovy.tools.GrapeUtilTest` class (preferred) or add some test(s) to `groovy.grape.GrapeIvyTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert edited a comment on pull request #1643: fix ArrayIndexOutOfBoundsException
Posted by GitBox <gi...@apache.org>.
paulk-asert edited a comment on pull request #1643:
URL: https://github.com/apache/groovy/pull/1643#issuecomment-946242209
Hi, this change looks good. Would you be able to add a test to your PR? I would suggest creating a new `org.codehaus.groovy.tools.GrapeUtilTest` class (preferred) or add some test(s) to `groovy.grape.GrapeIvyTest`.
In terms of the _legal format_, we defer to formats support by Ivy and Gradle/Maven.
Ivy format is captured here (but not related to the issues you found):
https://github.com/apache/groovy/blob/master/src/main/java/groovy/grape/GrabAnnotationTransformation.java#L111
For Gradle/Maven, we refer back to Gradle doco as mentioned here (it would have possibly been better if we had moved this into that utility method):
https://github.com/apache/groovy/blob/master/src/main/java/groovy/grape/GrabAnnotationTransformation.java#L563
Unfortunately, that link is outdated and should point to either the original:
https://docs.gradle.org/3.5.1/userguide/dependency_management.html#sec:how_to_declare_your_dependencies
Or something newer like:
https://docs.gradle.org/7.2/userguide/declaring_dependencies.html
(I'll change this last bit).
**Update**: I changed the outdated links in `GrabAnnotationTransformation`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1643: fix ArrayIndexOutOfBoundsException
Posted by GitBox <gi...@apache.org>.
paulk-asert merged pull request #1643:
URL: https://github.com/apache/groovy/pull/1643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert edited a comment on pull request #1643: fix ArrayIndexOutOfBoundsException
Posted by GitBox <gi...@apache.org>.
paulk-asert edited a comment on pull request #1643:
URL: https://github.com/apache/groovy/pull/1643#issuecomment-946242209
Hi, this change looks good. Would you be able to add a test to your PR? I would suggest creating a new `org.codehaus.groovy.tools.GrapeUtilTest` class (preferred) or add some test(s) to `groovy.grape.GrapeIvyTest`.
In terms of the _legal format_, we defer to formats support by Ivy and Gradle/Maven.
Ivy format is captured here (but not related to the issues you found):
https://github.com/apache/groovy/blob/master/src/main/java/groovy/grape/GrabAnnotationTransformation.java#L111
For Gradle/Maven, we refer back to Gradle doco as mentioned here (it would have possibly been better if we had moved this into that utility method):
https://github.com/apache/groovy/blob/master/src/main/java/groovy/grape/GrabAnnotationTransformation.java#L563
Unfortunately, that link is outdated and should point to either the original:
https://docs.gradle.org/3.5.1/userguide/dependency_management.html#sec:how_to_declare_your_dependencies
Or something newer like:
https://docs.gradle.org/7.2/userguide/declaring_dependencies.html
(I'll change this last bit).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1643: fix ArrayIndexOutOfBoundsException
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1643:
URL: https://github.com/apache/groovy/pull/1643#issuecomment-946430771
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org