You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/06/18 11:08:45 UTC

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #15262: [MXNET-1417][Performance] Caching Dynamic Shape Checking Result

ZhennanQin commented on a change in pull request #15262: [MXNET-1417][Performance] Caching Dynamic Shape Checking Result
URL: https://github.com/apache/incubator-mxnet/pull/15262#discussion_r294734503
 
 

 ##########
 File path: src/imperative/cached_op.h
 ##########
 @@ -70,6 +71,9 @@ struct CachedOpConfig : public dmlc::Parameter<CachedOpConfig> {
     DMLC_DECLARE_FIELD(is_dynamic)
     .set_default(false)
     .describe("Whether the graph contains dynamic shape operators.");
+    DMLC_DECLARE_FIELD(dynamic_shape_checked)
 
 Review comment:
   Seems it's an internal state of cached_op, I suggest not expose this to end-user.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services