You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/24 13:57:20 UTC

[GitHub] [arrow] huitseeker opened a new pull request #9006: ARROW-11028: [Rust] Make a few pattern matches more idiomatic

huitseeker opened a new pull request #9006:
URL: https://github.com/apache/arrow/pull/9006


   Some pattern-matches can be replaced by a direct combinator equivalent.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io edited a comment on pull request #9006: ARROW-11028: [Rust] Make a few pattern matches more idiomatic

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9006:
URL: https://github.com/apache/arrow/pull/9006#issuecomment-750893864


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=h1) Report
   > Merging [#9006](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=desc) (ae4f26d) into [master](https://codecov.io/gh/apache/arrow/commit/1ecef42bb9fb9e91f0fb04c7d5a1c3be58390025?el=desc) (1ecef42) will **decrease** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9006/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9006      +/-   ##
   ==========================================
   - Coverage   82.65%   82.65%   -0.01%     
   ==========================================
     Files         200      200              
     Lines       49795    49790       -5     
   ==========================================
   - Hits        41159    41153       -6     
   - Misses       8636     8637       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow/pull/9006/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0X2Rlcml2ZS9zcmMvcGFycXVldF9maWVsZC5ycw==) | `83.71% <ø> (ø)` | |
   | [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9006/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.73% <100.00%> (ø)` | |
   | [rust/arrow/src/compute/kernels/cast.rs](https://codecov.io/gh/apache/arrow/pull/9006/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2Nhc3QucnM=) | `96.83% <100.00%> (-0.01%)` | :arrow_down: |
   | [rust/datafusion/src/physical\_plan/expressions.rs](https://codecov.io/gh/apache/arrow/pull/9006/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zLnJz) | `84.48% <100.00%> (-0.02%)` | :arrow_down: |
   | [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9006/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=footer). Last update [ca685a0...ae4f26d](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #9006: ARROW-11028: [Rust] Make a few pattern matches more idiomatic

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9006:
URL: https://github.com/apache/arrow/pull/9006#issuecomment-750893864


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=h1) Report
   > Merging [#9006](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=desc) (7d8b8ff) into [master](https://codecov.io/gh/apache/arrow/commit/1ecef42bb9fb9e91f0fb04c7d5a1c3be58390025?el=desc) (1ecef42) will **decrease** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9006/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9006      +/-   ##
   ==========================================
   - Coverage   82.65%   82.65%   -0.01%     
   ==========================================
     Files         200      200              
     Lines       49795    49790       -5     
   ==========================================
   - Hits        41159    41154       -5     
     Misses       8636     8636              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow/pull/9006/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0X2Rlcml2ZS9zcmMvcGFycXVldF9maWVsZC5ycw==) | `83.71% <ø> (ø)` | |
   | [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9006/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.73% <100.00%> (ø)` | |
   | [rust/arrow/src/compute/kernels/cast.rs](https://codecov.io/gh/apache/arrow/pull/9006/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2Nhc3QucnM=) | `96.83% <100.00%> (-0.01%)` | :arrow_down: |
   | [rust/datafusion/src/physical\_plan/expressions.rs](https://codecov.io/gh/apache/arrow/pull/9006/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zLnJz) | `84.48% <100.00%> (-0.02%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=footer). Last update [ca685a0...ae4f26d](https://codecov.io/gh/apache/arrow/pull/9006?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9006: ARROW-11028: [Rust] Make a few pattern matches more idiomatic

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9006:
URL: https://github.com/apache/arrow/pull/9006#issuecomment-750893626


   https://issues.apache.org/jira/browse/ARROW-11028


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] huitseeker commented on pull request #9006: ARROW-11028: [Rust] Make a few pattern matches more idiomatic

Posted by GitBox <gi...@apache.org>.
huitseeker commented on pull request #9006:
URL: https://github.com/apache/arrow/pull/9006#issuecomment-751496440


   @jorgecarleitao done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9006: ARROW-11028: [Rust] Make a few pattern matches more idiomatic

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9006:
URL: https://github.com/apache/arrow/pull/9006#issuecomment-751462518


   Thanks for the contribution @huitseeker !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao closed pull request #9006: ARROW-11028: [Rust] Make a few pattern matches more idiomatic

Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9006:
URL: https://github.com/apache/arrow/pull/9006


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #9006: ARROW-11028: [Rust] Make a few pattern matches more idiomatic

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9006:
URL: https://github.com/apache/arrow/pull/9006#issuecomment-751451714


   @huitseeker , could you rebase?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org