You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Michael Matz (JIRA)" <de...@myfaces.apache.org> on 2006/10/05 22:00:20 UTC
[jira] Created: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
newspaperColumns attribute ignores EL expression
------------------------------------------------
Key: TOMAHAWK-728
URL: http://issues.apache.org/jira/browse/TOMAHAWK-728
Project: MyFaces Tomahawk
Issue Type: Bug
Components: Extended Datatable, Newspaper Table
Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT
Reporter: Michael Matz
If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485293 ]
Mike Kienenberger commented on TOMAHAWK-728:
--------------------------------------------
Oops. Apparently I already said this earlier -- I had comments turned off when I first came into this issue.
To answer your question: How do i create a "unified diff patch against the latest cvs code"?
Check out the code from svn (which you must already be doing).
Use your IDE or svn client to "Create patch" -- if you have a specific client, ask on the user list for specific directions. For eclipse, it's under "Team -> Create patch". For TortoiseSvn, it's under "TortoiseSvn -> Create Patch".
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable, Newspaper Table
> Affects Versions: 1.1.4-SNAPSHOT
> Reporter: Michael Matz
> Attachments: HtmlDataTable.java, HtmlNewspaperTable.java
>
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Jeff Bischoff (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485554 ]
Jeff Bischoff commented on TOMAHAWK-728:
----------------------------------------
You can also take a look at the Wiki page for contributing patches. We've added an example of making a patch from the command line as well, if that's easier for you.
[1] http://wiki.apache.org/myfaces/Contributing_Patches
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable, Newspaper Table
> Affects Versions: 1.1.4-SNAPSHOT
> Reporter: Michael Matz
> Attachments: HtmlDataTable.java, HtmlNewspaperTable.java
>
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-728?page=comments#action_12454726 ]
Mike Kienenberger commented on TOMAHAWK-728:
--------------------------------------------
Michael,
Your patches will be more likely to be accepted if you submit these as a unified diff patch against the latest cvs code rather than as the whole file from an older version.
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Newspaper Table, Extended Datatable
> Affects Versions: 1.1.4-SNAPSHOT
> Reporter: Michael Matz
> Attachments: HtmlDataTable.java, HtmlNewspaperTable.java
>
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Kienenberger updated TOMAHAWK-728:
---------------------------------------
Status: Open (was: Patch Available)
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable, Newspaper Table
> Affects Versions: 1.1.4-SNAPSHOT
> Reporter: Michael Matz
> Attachments: HtmlDataTable.java, HtmlNewspaperTable.java
>
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Michael Heinen (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488378 ]
Michael Heinen commented on TOMAHAWK-728:
-----------------------------------------
damn, Of course I wanted to grant ASF Granted License.
Do I have to upload it again, or is it ok with this statement?
"ASF Granted License" granted.
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable, Newspaper Table
> Affects Versions: 1.1.4-SNAPSHOT
> Reporter: Michael Matz
> Attachments: HtmlDataTable.java, HtmlDataTable.patch, HtmlNewspaperTable.java
>
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485290 ]
Mike Kienenberger commented on TOMAHAWK-728:
--------------------------------------------
Michael,
This sounds like a good patch.
However, you need to submit it unified diff format -- we can't process entire java files, especially when they're 46Kb :-)
This is probably why no one has taken a look at this patch up to this point.
I recommend fixing getNewspaperOrientation() at the same time.
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable, Newspaper Table
> Affects Versions: 1.1.4-SNAPSHOT
> Reporter: Michael Matz
> Attachments: HtmlDataTable.java, HtmlNewspaperTable.java
>
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488380 ]
Mike Kienenberger commented on TOMAHAWK-728:
--------------------------------------------
It would be better if you uploaded it again so there's a clear legal trail.
I'll delete the other one once you've done that.
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable, Newspaper Table
> Affects Versions: 1.1.4-SNAPSHOT
> Reporter: Michael Matz
> Attachments: HtmlDataTable.java, HtmlDataTable.patch, HtmlNewspaperTable.java
>
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Michael Matz (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-728?page=all ]
Michael Matz updated TOMAHAWK-728:
----------------------------------
Status: Patch Available (was: Open)
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable, Newspaper Table
> Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT
> Reporter: Michael Matz
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Grant Smith (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519115 ]
Grant Smith commented on TOMAHAWK-728:
--------------------------------------
I think this issue might have been resolved by TOMAHAWK-955 ?
Can we close it ?
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable, Newspaper Table
> Affects Versions: 1.1.4-SNAPSHOT
> Reporter: Michael Matz
> Attachments: HtmlDataTable.java, HtmlDataTable.patch, HtmlDataTable.patch, HtmlNewspaperTable.java
>
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Michael Matz (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-728?page=all ]
Michael Matz updated TOMAHAWK-728:
----------------------------------
Status: Patch Available (was: Open)
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable, Newspaper Table
> Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT
> Reporter: Michael Matz
> Attachments: HtmlDataTable.java
>
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Michael Matz (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-728?page=all ]
Michael Matz updated TOMAHAWK-728:
----------------------------------
Status: Open (was: Patch Available)
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable, Newspaper Table
> Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT
> Reporter: Michael Matz
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Michael Matz (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-728?page=comments#action_12454762 ]
Michael Matz commented on TOMAHAWK-728:
---------------------------------------
Mike,
I'm new at this. How do i create a "unified diff patch against the latest cvs code"? Thanks.
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Newspaper Table, Extended Datatable
> Affects Versions: 1.1.4-SNAPSHOT
> Reporter: Michael Matz
> Attachments: HtmlDataTable.java, HtmlNewspaperTable.java
>
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-728) newspaperColumns attribute ignores
EL expression
Posted by "Dave (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492432 ]
Dave commented on TOMAHAWK-728:
-------------------------------
How is the progress of this patch? Could you please check in this patch ASAP. Thanks!!
> newspaperColumns attribute ignores EL expression
> ------------------------------------------------
>
> Key: TOMAHAWK-728
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-728
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Extended Datatable, Newspaper Table
> Affects Versions: 1.1.4-SNAPSHOT
> Reporter: Michael Matz
> Attachments: HtmlDataTable.java, HtmlDataTable.patch, HtmlDataTable.patch, HtmlNewspaperTable.java
>
>
> If you use an EL expression for the newspaperColumns attribute it is ignored and the default value of 1 is used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.