You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/05 16:50:28 UTC
[GitHub] [rocketmq] horizonzy opened a new pull request #2555: [ISSUE #2554] Reuse properties which parse from MessageDecoder.string2messageProperties(requestHeader.getProperties())
horizonzy opened a new pull request #2555:
URL: https://github.com/apache/rocketmq/pull/2555
## What is the purpose of the change
For-#2554
Reuse properties which parse from MessageDecoder.string2messageProperties(requestHeader.getProperties())
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io commented on pull request #2555: [ISSUE #2554] Reuse properties which parse from MessageDecoder.string2messageProperties(requestHeader.getProperties())
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2555:
URL: https://github.com/apache/rocketmq/pull/2555#issuecomment-754779490
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2555?src=pr&el=h1) Report
> Merging [#2555](https://codecov.io/gh/apache/rocketmq/pull/2555?src=pr&el=desc) (ea8c10d) into [develop](https://codecov.io/gh/apache/rocketmq/commit/0239421fa59b67c423cf9fcabf5cd6edda0c2076?el=desc) (0239421) will **increase** coverage by `0.15%`.
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/rocketmq/pull/2555?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2555 +/- ##
=============================================
+ Coverage 45.97% 46.12% +0.15%
- Complexity 4318 4336 +18
=============================================
Files 547 547
Lines 36236 36247 +11
Branches 4808 4808
=============================================
+ Hits 16658 16718 +60
+ Misses 17491 17444 -47
+ Partials 2087 2085 -2
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2555?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ocketmq/broker/processor/SendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2555/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1NlbmRNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `41.01% <40.00%> (ø)` | `26.00 <0.00> (ø)` | |
| [...apache/rocketmq/remoting/netty/ResponseFuture.java](https://codecov.io/gh/apache/rocketmq/pull/2555/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Jlc3BvbnNlRnV0dXJlLmphdmE=) | `85.00% <0.00%> (-5.00%)` | `16.00% <0.00%> (-2.00%)` | |
| [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/2555/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `57.67% <0.00%> (-4.19%)` | `31.00% <0.00%> (-1.00%)` | |
| [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://codecov.io/gh/apache/rocketmq/pull/2555/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | `46.86% <0.00%> (-4.06%)` | `20.00% <0.00%> (-2.00%)` | |
| [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2555/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.98% <0.00%> (-3.62%)` | `16.00% <0.00%> (ø%)` | |
| [...mq/client/consumer/store/LocalFileOffsetStore.java](https://codecov.io/gh/apache/rocketmq/pull/2555/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvTG9jYWxGaWxlT2Zmc2V0U3RvcmUuamF2YQ==) | `56.86% <0.00%> (-1.97%)` | `19.00% <0.00%> (ø%)` | |
| [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2555/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-1.50%)` | `16.00% <0.00%> (-1.00%)` | |
| [...che/rocketmq/namesrv/kvconfig/KVConfigManager.java](https://codecov.io/gh/apache/rocketmq/pull/2555/diff?src=pr&el=tree#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9rdmNvbmZpZy9LVkNvbmZpZ01hbmFnZXIuamF2YQ==) | `59.18% <0.00%> (-1.03%)` | `11.00% <0.00%> (-1.00%)` | |
| [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/2555/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | `73.60% <0.00%> (-0.51%)` | `17.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2555/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `66.42% <0.00%> (-0.11%)` | `79.00% <0.00%> (ø%)` | |
| ... and [20 more](https://codecov.io/gh/apache/rocketmq/pull/2555/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2555?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2555?src=pr&el=footer). Last update [0239421...ea8c10d](https://codecov.io/gh/apache/rocketmq/pull/2555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2555: [ISSUE #2554] Reuse properties which parse from MessageDecoder.string2messageProperties(requestHeader.getProperties())
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2555:
URL: https://github.com/apache/rocketmq/pull/2555#issuecomment-754769825
[](https://coveralls.io/builds/36125669)
Coverage decreased (-0.1%) to 51.832% when pulling **63682575665834f5cd5f7df6427ad6f4ae92a152 on horizonzy:fix-2554** into **98aca7ffcbf282b2885ad4b9c433927a5ac0e78b on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2555: [ISSUE #2554] Reuse properties which parse from MessageDecoder.string2messageProperties(requestHeader.getProperties())
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2555:
URL: https://github.com/apache/rocketmq/pull/2555#issuecomment-754769825
[](https://coveralls.io/builds/46876964)
Coverage increased (+0.03%) to 51.582% when pulling **625ae68c167677714adddea86ac8f16204d412da on horizonzy:fix-2554** into **b606d9c638c2b9bf018d9a9968fdc9e5d6acf07f on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2555: [ISSUE #2554] Reuse properties which parse from MessageDecoder.string2messageProperties(requestHeader.getProperties())
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2555:
URL: https://github.com/apache/rocketmq/pull/2555#issuecomment-754769825
[](https://coveralls.io/builds/36100893)
Coverage decreased (-0.01%) to 51.922% when pulling **ea8c10da05bd0e146ecec6c0aa5c8864a492caa2 on horizonzy:fix-2554** into **98aca7ffcbf282b2885ad4b9c433927a5ac0e78b on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org