[GitHub] [cordova-windows] erisu edited a comment on issue #325: Cordova platform add windows@^7.0.0 command not copying the node_modules

[GitBox <gi...@apache.org>]

erisu edited a comment on issue #325: Cordova platform add windows@^7.0.0 command not copying the node_modules
URL: https://github.com/apache/cordova-windows/issues/325#issuecomment-471522052
 
 
   @aman2604 This is not a side effect of PR #317 and is the expected behavior.
   
   Node modules are no longer bundled in any of the platforms including `cordova-windows`.  
   
   What PR #317 does is copies the `node_modules` folder only if it is present. Since there is no `node_modules` directory, it has nothing to copy. The use case where the `node_module` directory exists is from stand alone non-CLI usage.
   
   For more information, you can check out these two tickets:
   - https://github.com/apache/cordova/issues/32: This ticket is to create #317 
   - https://github.com/apache/cordova/issues/6: This ticket is what removed bundled node modules.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org