You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/10 22:34:53 UTC
[GitHub] [spark] alex-balikov opened a new pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
alex-balikov opened a new pull request #35810:
URL: https://github.com/apache/spark/pull/35810
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
As described in [SPARK-38320](https://issues.apache.org/jira/browse/SPARK-38320), the bug is that it is possible for (flat)MapGroupsWithState to timeout a key even if that key received data within the same batch. This is against the documented (flat)MapGroupsWithState contract. The problem is due to the StateStore.iterator not reflecting StateStore changes made *after* its creation - this is illustrated in the test this PR adds to StateStoreSuite.scala.
The fix is to *late bind* the timeoutProcessorIter timeout processing iterator in FlatMapGroupsWithStateExec to be created *after* the input iterator has been exhausted and the state changes applied to the StateStore.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The changes are needed to ensure the state timeout processing iterator for (flat)MapGroupsWithState is created *after* the input is processed and the changes are applied into the StateStore, otherwise it may not notice these changes (the change to the key timeout timestamp being updates as part of the input processing).
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No. Bug fix.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
* Added a test to StateStoreSuite.scala to illustrate the difference of state store iterator behavior across the different implementations of state stores. In particular the test illustrates the RocksDB state store iterator not reflecting state store changes made after its creation.
* Added test to FlatMapGroupsWithStateSuite.scala which would fail with unexpected state timeout if the issue was not fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] alex-balikov commented on pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
Posted by GitBox <gi...@apache.org>.
alex-balikov commented on pull request #35810:
URL: https://github.com/apache/spark/pull/35810#issuecomment-1064588421
@HeartSaVioR can you please review. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #35810:
URL: https://github.com/apache/spark/pull/35810#issuecomment-1064645352
I'll keep this open for today to see further feedback. I'll merge if there is no outstanding comment in tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on pull request #35810:
URL: https://github.com/apache/spark/pull/35810#issuecomment-1066026305
I don't see any outstanding unresolved comment now. Thanks! Merging to master/3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] alex-balikov commented on a change in pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
Posted by GitBox <gi...@apache.org>.
alex-balikov commented on a change in pull request #35810:
URL: https://github.com/apache/spark/pull/35810#discussion_r824363655
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala
##########
@@ -172,12 +172,20 @@ case class FlatMapGroupsWithStateExec(
timeoutProcessingStartTimeNs = System.nanoTime
})
- val timeoutProcessorIter =
- CompletionIterator[InternalRow, Iterator[InternalRow]](processor.processTimedOutState(), {
- // Note: `timeoutLatencyMs` also includes the time the parent operator took for
- // processing output returned through iterator.
- timeoutLatencyMs += NANOSECONDS.toMillis(System.nanoTime - timeoutProcessingStartTimeNs)
- })
+ // SPARK-38204: Late-bind the timeout processing iterator so it is created *after* the input is
Review comment:
Thanks for the catch. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on a change in pull request #35810:
URL: https://github.com/apache/spark/pull/35810#discussion_r824310506
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala
##########
@@ -172,12 +172,20 @@ case class FlatMapGroupsWithStateExec(
timeoutProcessingStartTimeNs = System.nanoTime
})
- val timeoutProcessorIter =
- CompletionIterator[InternalRow, Iterator[InternalRow]](processor.processTimedOutState(), {
- // Note: `timeoutLatencyMs` also includes the time the parent operator took for
- // processing output returned through iterator.
- timeoutLatencyMs += NANOSECONDS.toMillis(System.nanoTime - timeoutProcessingStartTimeNs)
- })
+ // SPARK-38204: Late-bind the timeout processing iterator so it is created *after* the input is
Review comment:
Nice finding :)
@alex-balikov looks like JIRA ticket is not properly mentioned here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR closed pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
Posted by GitBox <gi...@apache.org>.
HeartSaVioR closed pull request #35810:
URL: https://github.com/apache/spark/pull/35810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #35810:
URL: https://github.com/apache/spark/pull/35810#issuecomment-1066026305
I don't see any outstanding unresolved comment now. Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35810:
URL: https://github.com/apache/spark/pull/35810#discussion_r824306177
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala
##########
@@ -172,12 +172,20 @@ case class FlatMapGroupsWithStateExec(
timeoutProcessingStartTimeNs = System.nanoTime
})
- val timeoutProcessorIter =
- CompletionIterator[InternalRow, Iterator[InternalRow]](processor.processTimedOutState(), {
- // Note: `timeoutLatencyMs` also includes the time the parent operator took for
- // processing output returned through iterator.
- timeoutLatencyMs += NANOSECONDS.toMillis(System.nanoTime - timeoutProcessingStartTimeNs)
- })
+ // SPARK-38204: Late-bind the timeout processing iterator so it is created *after* the input is
Review comment:
SPARK-38204 or SPARK-38320?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35810:
URL: https://github.com/apache/spark/pull/35810#issuecomment-1064953271
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #35810:
URL: https://github.com/apache/spark/pull/35810#issuecomment-1064589872
Thanks for pinging me. I'll review this today.
cc. @tdas @zsxwing @viirya @xuanyuanking for seeking another eyes of reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #35810: [SPARK-38320][SS] Fix flatMapGroupsWithState timeout in batch with data for key
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #35810:
URL: https://github.com/apache/spark/pull/35810#issuecomment-1066028215
Thanks @alex-balikov for the contribution! I merged into master/3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org