You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Andrea Gazzarini <a....@gmail.com> on 2008/11/17 13:51:03 UTC

QMan does not support all available data types [QPID-1463]

Hi All, in order to fix the QPID-1463 several methods should be added to
existing classes XXXDecoder XXXEncoder.I'm talking about read/writeFloat()
and read/writeDouble methods.

Now, I saw that that we have the following class hierarchy :
Decoder <-- AbstractDecoder <-- BBDecoder
Encoder <-- AbstractEncoder <-- BBEncoder

Those classes are not mine so, before proceeding with some changes, I think
should be better to ask you what you are thinking about..

- Do you think those methods should be added on the top level hierarchy
interface (Decoder & Encoder)?
- Do you think their implementation should be on BBDecoder & BBEncoder? I'm
sayiong that becayse the ByteBuffer class already  has putFloat/Double and
getFloat/Double methods.

Let me know

Best Regards,
Andrea

Re: QMan does not support all available data types [QPID-1463]

Posted by Rafael Schloming <ra...@redhat.com>.
Andrea Gazzarini wrote:
> Hi All, in order to fix the QPID-1463 several methods should be added to
> existing classes XXXDecoder XXXEncoder.I'm talking about read/writeFloat()
> and read/writeDouble methods.
> 
> Now, I saw that that we have the following class hierarchy :
> Decoder <-- AbstractDecoder <-- BBDecoder
> Encoder <-- AbstractEncoder <-- BBEncoder
> 
> Those classes are not mine so, before proceeding with some changes, I think
> should be better to ask you what you are thinking about..
> 
> - Do you think those methods should be added on the top level hierarchy
> interface (Decoder & Encoder)?

Yes

> - Do you think their implementation should be on BBDecoder & BBEncoder? I'm
> sayiong that becayse the ByteBuffer class already  has putFloat/Double and
> getFloat/Double methods.

Yes

--Rafael