You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by tp...@apache.org on 2014/07/22 22:52:12 UTC
svn commit: r1612701 - in
/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser:
image/ImageMetadataExtractor.java microsoft/HSLFExtractor.java
microsoft/SummaryExtractor.java
Author: tpalsulich
Date: Tue Jul 22 20:52:12 2014
New Revision: 1612701
URL: http://svn.apache.org/r1612701
Log:
Remove unnecessary boxing and unboxing.
Modified:
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/image/ImageMetadataExtractor.java
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/HSLFExtractor.java
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/SummaryExtractor.java
Modified: tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/image/ImageMetadataExtractor.java
URL: http://svn.apache.org/viewvc/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/image/ImageMetadataExtractor.java?rev=1612701&r1=1612700&r2=1612701&view=diff
==============================================================================
--- tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/image/ImageMetadataExtractor.java (original)
+++ tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/image/ImageMetadataExtractor.java Tue Jul 22 20:52:12 2014
@@ -329,7 +329,7 @@ public class ImageMetadataExtractor {
if(directory.containsTag(ExifIFD0Directory.TAG_ORIENTATION)) {
Object length = directory.getObject(ExifIFD0Directory.TAG_ORIENTATION);
if(length instanceof Integer) {
- metadata.set(Metadata.ORIENTATION, Integer.toString( ((Integer)length).intValue() ));
+ metadata.set(Metadata.ORIENTATION, Integer.toString((Integer)length));
} else {
metadata.set(Metadata.ORIENTATION, directory.getString(ExifIFD0Directory.TAG_ORIENTATION));
}
@@ -442,8 +442,8 @@ public class ImageMetadataExtractor {
if (geoLocation != null) {
DecimalFormat geoDecimalFormat = new DecimalFormat(GEO_DECIMAL_FORMAT_STRING,
new DecimalFormatSymbols(Locale.ENGLISH));
- metadata.set(TikaCoreProperties.LATITUDE, geoDecimalFormat.format(new Double(geoLocation.getLatitude())));
- metadata.set(TikaCoreProperties.LONGITUDE, geoDecimalFormat.format(new Double(geoLocation.getLongitude())));
+ metadata.set(TikaCoreProperties.LATITUDE, geoDecimalFormat.format(geoLocation.getLatitude()));
+ metadata.set(TikaCoreProperties.LONGITUDE, geoDecimalFormat.format(geoLocation.getLongitude()));
}
}
}
Modified: tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/HSLFExtractor.java
URL: http://svn.apache.org/viewvc/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/HSLFExtractor.java?rev=1612701&r1=1612700&r2=1612701&view=diff
==============================================================================
--- tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/HSLFExtractor.java (original)
+++ tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/HSLFExtractor.java Tue Jul 22 20:52:12 2014
@@ -135,7 +135,7 @@ public class HSLFExtractor extends Abstr
if (notes == null) {
continue;
}
- Integer id = Integer.valueOf(notes._getSheetNumber());
+ Integer id = notes._getSheetNumber();
if (seenNotes.contains(id)) {
continue;
}
Modified: tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/SummaryExtractor.java
URL: http://svn.apache.org/viewvc/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/SummaryExtractor.java?rev=1612701&r1=1612700&r2=1612701&view=diff
==============================================================================
--- tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/SummaryExtractor.java (original)
+++ tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/microsoft/SummaryExtractor.java Tue Jul 22 20:52:12 2014
@@ -192,7 +192,7 @@ public class SummaryExtractor {
metadata.set(prop, ((Long)value).intValue());
} else if (value instanceof Double) {
Property prop = Property.externalReal(key);
- metadata.set(prop, ((Double)value).doubleValue());
+ metadata.set(prop, (Double)value);
} else if (value instanceof Integer) {
Property prop = Property.externalInteger(key);
metadata.set(prop, ((Integer)value).intValue());