You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Harry Metske (JIRA)" <ji...@apache.org> on 2010/01/31 19:23:34 UTC

[jira] Updated: (JSPWIKI-633) changenote and replaceEntities done multiple times

     [ https://issues.apache.org/jira/browse/JSPWIKI-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harry Metske updated JSPWIKI-633:
---------------------------------

    Security:     (was: Security Vulnerability Disclosure)

> changenote and replaceEntities done multiple times
> --------------------------------------------------
>
>                 Key: JSPWIKI-633
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-633
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage, Default template
>    Affects Versions: 2.8.3
>         Environment: Redhat Linux, Tomcat 6.0.16
>            Reporter: Stefan Bohn
>            Assignee: Harry Metske
>            Priority: Minor
>             Fix For: 2.8.4
>
>         Attachments: ff.patch
>
>
> When editing a page, you can enter the changenote.
> Edit.jsp, Line 45:
> String changenote = TextUtil.replaceEntities( findParam( pageContext, "changenote" ) );
> RecentChangePlugin.java, Line 217
> row.addElement( new td(changenote != null ? TextUtil.replaceEntities(changenote) : "").setClass("changenote") );
> So the entities of the text entered via Edit.jsp are replaced twice.
> PageRenamer.java Lines 139 and 206:
> p.setAttribute( WikiPage.CHANGENOTE, fromPage.getName()+" ==> "+toPage.getName() );
> TextUtil.replaceEntities is not called.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.