[GitHub] [lucene] rmuir commented on a diff in pull request #12583: Fix hidden range embedded in UAX29URLEmail grammar

["rmuir (via GitHub)" <gi...@apache.org>]

rmuir commented on code in PR #12583:
URL: https://github.com/apache/lucene/pull/12583#discussion_r1334328967


##########
lucene/analysis/common/src/test/org/apache/lucene/analysis/email/TestUAX29URLEmailAnalyzer.java:
##########
@@ -433,9 +433,9 @@ public void testMailtoSchemeEmails() throws Exception {
         new String[] {
           "mailto",
           "persona@example.com",
-          // TODO: recognize ',' address delimiter. Also, see examples of ';' delimiter use at:
+          // Also, see examples of ';' delimiter use at:

Review Comment:
   yeah i don't know, I just tried to preserve these comments, and there are other similar TODO in the test. Especially this one: https://github.com/apache/lucene/blob/53ba27a63be6849d5383b8bfc6d1508dd7b66f0c/lucene/analysis/common/src/test/org/apache/lucene/analysis/email/TestUAX29URLEmailAnalyzer.java#L428C8-L428C96



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org