You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "leizhiyuan (via GitHub)" <gi...@apache.org> on 2024/08/20 08:57:19 UTC
[PR] [ISSUE #8549] ipv6 enabled in broker, pickupStoreTimestamp size should be 12 [rocketmq]
leizhiyuan opened a new pull request, #8567:
URL: https://github.com/apache/rocketmq/pull/8567
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #8549
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
ipv6 enabled in broker, pickupStoreTimestamp size should be 12
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8549] Ipv6 enabled in broker, pickupStoreTimestamp size should be 20 [rocketmq]
Posted by "woaishixiaoxiao (via GitHub)" <gi...@apache.org>.
woaishixiaoxiao commented on PR #8567:
URL: https://github.com/apache/rocketmq/pull/8567#issuecomment-3002719291
The `validator.isValidInet6Address` function only supports standard IPv6 addresses. brokerIP1 default get by NetworkUtil.getLocalAddress() will normalize by "[]", such as [2001:0db8:85a3:0000:0000:8a2e:0370:7334] and ipv6 address will contains scope in linux such as [2001:0db8:85a3:0000:0000:8a2e:0370:7334%eth0].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8549] Ipv6 enabled in broker, pickupStoreTimestamp size should be 20 [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8567:
URL: https://github.com/apache/rocketmq/pull/8567#issuecomment-2298753326
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8567?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `4 lines` in your changes missing coverage. Please review.
> Project coverage is 47.08%. Comparing base [(`8b7f9cc`)](https://app.codecov.io/gh/apache/rocketmq/commit/8b7f9cc5ef4ae40b8834df6dd0fd1f09a7f454bb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`978de98`)](https://app.codecov.io/gh/apache/rocketmq/commit/978de9831b65fc9116aa36316bfcd2ddca0e0365?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8567?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...org/apache/rocketmq/store/DefaultMessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/8567?src=pr&el=tree&filepath=store%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fstore%2FDefaultMessageStore.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8567 +/- ##
=============================================
- Coverage 47.08% 47.08% -0.01%
- Complexity 11372 11375 +3
=============================================
Files 1275 1275
Lines 89108 89111 +3
Branches 11467 11468 +1
=============================================
- Hits 41957 41955 -2
- Misses 41954 41968 +14
+ Partials 5197 5188 -9
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8567?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8549] Ipv6 enabled in broker, pickupStoreTimestamp size should be 20 [rocketmq]
Posted by "jaylu163 (via GitHub)" <gi...@apache.org>.
jaylu163 commented on PR #8567:
URL: https://github.com/apache/rocketmq/pull/8567#issuecomment-2461515110
5.2版本还有问题。有修改这个版本吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8549] Ipv6 enabled in broker, pickupStoreTimestamp size should be 20 [rocketmq]
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #8567:
URL: https://github.com/apache/rocketmq/pull/8567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org