You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/28 18:47:57 UTC

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6672: NIFI-10834 Fixed Flaky Test failing with NonDex

exceptionfactory commented on code in PR #6672:
URL: https://github.com/apache/nifi/pull/6672#discussion_r1033927066


##########
nifi-nar-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/test/java/org/apache/nifi/processors/splunk/TestPutSplunkHTTP.java:
##########
@@ -131,7 +172,7 @@ public void testHappyPathWithCustomQueryParameters() throws Exception {
 
         // then
         testRunner.assertAllFlowFilesTransferred(PutSplunkHTTP.RELATIONSHIP_SUCCESS, 1);
-        assertEquals("/services/collector/raw?sourcetype=test%3Fsource%3Ftype&source=test_source", path.getValue());
+        assertTrue(returnPermuations("/services/collector/raw?sourcetype=test%3Fsource%3Ftype&source=test_source").contains(path.getValue()));

Review Comment:
   ```suggestion
           assertTrue(path.getValue().startsWith("/services/collector/raw"));
   ```



##########
nifi-nar-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/test/java/org/apache/nifi/processors/splunk/TestPutSplunkHTTP.java:
##########
@@ -163,7 +204,7 @@ public void testHappyPathWithCustomQueryParametersFromFlowFile() throws Exceptio
 
         // then
         testRunner.assertAllFlowFilesTransferred(PutSplunkHTTP.RELATIONSHIP_SUCCESS, 1);
-        assertEquals("/services/collector/raw?host=test_host&index=test_index&sourcetype=test%3Fsource%3Ftype&source=test_source", path.getValue());
+        assertTrue(returnPermuations("/services/collector/raw?host=test_host&index=test_index&sourcetype=test%3Fsource%3Ftype&source=test_source").contains(path.getValue()));

Review Comment:
   ```suggestion
           assertTrue(path.getValue().startsWith("/services/collector/raw"));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org