You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Jeff Genender (JIRA)" <ji...@apache.org> on 2007/09/20 16:58:31 UTC

[jira] Created: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

SocketConnection cannot be manually closed (for v2.X)
-----------------------------------------------------

                 Key: DIRMINA-443
                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
             Project: MINA
          Issue Type: Bug
          Components: Core
    Affects Versions: 2.0.0-M1
            Reporter: Jeff Genender
             Fix For: 2.0.0-M1


The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trustin Lee resolved DIRMINA-443.
---------------------------------

    Resolution: Fixed

I checked in the patch.  Please confirm and close.

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch, DIRMINA-443.take2.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Maarten Bosteels (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530732 ] 

Maarten Bosteels commented on DIRMINA-443:
------------------------------------------

Trustin, my apologies., it seems that I was too quick with applying the patch. 
Will you revert it, or should I do it ?


> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Maarten Bosteels (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529425 ] 

Maarten Bosteels commented on DIRMINA-443:
------------------------------------------

Thanks for the patch.
I applied it to the trunk.

Should we also apply this to SerialConnector, DatagramConnector and VmPipeConnector ?

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Jeff Genender (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529433 ] 

Jeff Genender commented on DIRMINA-443:
---------------------------------------

Yes...I think a similar patch would be applicable to those connectors as well.

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Maarten Bosteels (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maarten Bosteels reassigned DIRMINA-443:
----------------------------------------

    Assignee: Maarten Bosteels

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530720 ] 

Trustin Lee commented on DIRMINA-443:
-------------------------------------

According to the applied patch:

            for (; ;) {
                try {
                    int nKeys = selector.select(1000);

                    if (closeFlag){
                        synchronized (lock) {
                            worker = null;
                            break;
                        }
                    }

it just breaks out of the loop, so any connection attempts in progress will not complete at all, possibly leading to FD leak.  Anyways, it seems like setting the timeout value to 0 do what you want.  What do you think about just adding more explanation of the behavior when timeout is 0, instead of adding a new method? :)

Moreover, We are going to implement a global pool of I/O threads so you won't even need to worry about such kind of leak in 2.0.

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530697 ] 

Trustin Lee commented on DIRMINA-443:
-------------------------------------

The patch can lead to unexpected termination of I/O threads even while there's a connection attempt in progress.  Why not just setting the timeout to 0?  It will make the thread to exit immediately when there's no connection to handle.

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530680 ] 

Trustin Lee commented on DIRMINA-443:
-------------------------------------

Could you explain a little bit more in detail about this issue?  I simply didn't get why the current implementation can cause OOM.  Is it because you create too many SocketConnectors, instead of using a shared instance?

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Jeff Genender (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530736 ] 

Jeff Genender commented on DIRMINA-443:
---------------------------------------

Well...the close() is shutting everything down, so we really don't want more connections ;-)  Isn't setting a timeout to 0 also a breakout of the loop in a similar fashion as the closeFlag? ;-)

However, I agree, setting the timeout to 0 will do what is needed here...but setting that seems counter intuitive.  I think having a close() method (which can set the timeout to zero) makes sense since it signifies you are shutting it down manually.  If not that, then it should be heavily documented in the wiki since this question (how to immediately shutdown a SocketConnection) seems to be a frequently asked question on the lists.  I say this because it took me a good few hours of going through the Mina code to figure out setting the timeout to 0 shuts it all down ;-) I'm just being nit-picky ;-)

May I submit a new patch to undo the first patch and have close() just set the timeout to 0, or a patch just to back it out all together and we live with the timeout=0?

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Maarten Bosteels (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530738 ] 

Maarten Bosteels commented on DIRMINA-443:
------------------------------------------

I agree that it makes sense to have a close() method

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Jeff Genender (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530704 ] 

Jeff Genender commented on DIRMINA-443:
---------------------------------------

How would it lead to an abnormal termination?  The Worker threads check for the closeFlag and they exit, almost no different from the timeout = 0.

I guess the close() could probably do a timeout = 0 which would do the same thing ;-)

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Jeff Genender (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Genender closed DIRMINA-443.
---------------------------------


Wow...that was fast! ;-)  Confirmed.

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch, DIRMINA-443.take2.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530741 ] 

Trustin Lee commented on DIRMINA-443:
-------------------------------------

"Well...the close() is shutting everything down, so we really don't want more connections ;-) Isn't setting a timeout to 0 also a breakout of the loop in a similar fashion as the closeFlag? ;-) "

Not exactly.  The breakout caused by timeout makes sure if the number of in-progress connection attempt is 0, so there's no FD leak.  However, just breaking out of the loop not checking the number can cause a FD leak or related ConnectFuture will not be notified at all.  And the worker will be executed again when there's any additional connection request.

Once again, we will get rid of the timeout property and maintain a pool of I/O workers (including NioProcessor and workers in SocketAcceptor and SocketConnector), so please consider the timeout property as a temporary workaround for a performance issue.  Therefore, even if we decide to retain the close() method, it will go away when the first milestone of MINA 2 is released.

Anyways, please feel free to provide us a new patch that modifies the behavior of the close() method.

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Jeff Genender (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Genender updated DIRMINA-443:
----------------------------------

    Attachment: DIRMINA-443.take2.patch

Fixes the close() to use the timeout.

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch, DIRMINA-443.take2.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Jeff Genender (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Genender updated DIRMINA-443:
----------------------------------

    Attachment: DIRMINA-443-jgenender.patch

Patch attached allows SocketConnector to be closed.

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Jeff Genender (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530743 ] 

Jeff Genender commented on DIRMINA-443:
---------------------------------------

Ok...I see the code for the timeout and thus the differences...sorry about that...I should have checked earlier.

Patch attached...but if this will truly go away, then no worries. ;-)

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch, DIRMINA-443.take2.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-443) SocketConnection cannot be manually closed (for v2.X)

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530735 ] 

Trustin Lee commented on DIRMINA-443:
-------------------------------------

No need to apologize.  It's trunk anyway! :D

Let's wait for Jeff's comment in case we are missing something.

> SocketConnection cannot be manually closed (for v2.X)
> -----------------------------------------------------
>
>                 Key: DIRMINA-443
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-443
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Jeff Genender
>            Assignee: Maarten Bosteels
>             Fix For: 2.0.0-M1
>
>         Attachments: DIRMINA-443-jgenender.patch
>
>
> The SocketConnection cannot be closed. Currently it will wait a certain amount of timeout as specified by the worker timeout to shut down the connection. This can result in OOM and hanging clients until the timeouts occur. Mina should allow the SocketConnection to be closed manually if the connection is known to be completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.