You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by davies <gi...@git.apache.org> on 2014/10/02 09:27:02 UTC
[GitHub] spark pull request: [SPARK-2461] Add a toString method to Generali...
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/2625
[SPARK-2461] Add a toString method to GeneralizedLinearModel
Add a toString method to GeneralizedLinearModel, also change `__str__` to `__repr__` for some classes, to provide better message in repr.
This PR is based on #1388, thanks to @sryza!
closes #1388
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davies/spark string
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2625
----
commit f7b58ed25d8228c25cac0fc72616fb6ebb392959
Author: Sandy Ryza <sa...@cloudera.com>
Date: 2014-07-12T19:46:35Z
SPARK-2461. Add a toString method to GeneralizedLinearModel
commit fac1bc44d57db1c0fb23f0b246b21373b397781e
Author: Sandy Ryza <sa...@cloudera.com>
Date: 2014-08-31T17:51:03Z
Fix PEP8 error
commit 1aa17f57bc9ac74d68ca5a5235c3a0d0cc197993
Author: Sandy Ryza <sa...@cloudera.com>
Date: 2014-09-02T06:52:36Z
Match existing conventions
commit a0c5041910dcfc1491c01954d9234336172e0f7b
Author: Sandy Ryza <sa...@cloudera.com>
Date: 2014-09-02T18:46:10Z
Add labels back in
commit aa9e962de5b56a71bbd67ef9efe9aad018f1d73c
Author: Sandy Ryza <sa...@cloudera.com>
Date: 2014-09-04T08:43:01Z
Switch __str__ to __repr__
commit 1ce5c2d12c5fd4e078907903a138232e67f24335
Author: Sandy Ryza <sa...@cloudera.com>
Date: 2014-09-10T20:59:32Z
__repr__ back to __str__ in a couple places
commit 0bcd642e1ad77a64de8ec9cde5405f1907099b93
Author: Davies Liu <da...@gmail.com>
Date: 2014-10-02T07:19:40Z
Merge branch 'sandy-spark-2461' of github.com:sryza/spark
Conflicts:
python/pyspark/mllib/linalg.py
python/pyspark/mllib/regression.py
python/pyspark/mllib/tree.py
commit 3544aad2bd5fe691d72db930112252914e63cc5b
Author: Davies Liu <da...@gmail.com>
Date: 2014-10-02T07:23:07Z
fix LinearModel
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2461] [PySpark] Add a toString method t...
Posted by sryza <gi...@git.apache.org>.
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/2625#issuecomment-57593551
Thanks for picking this up @davies. This looks good to me if Jenkins OKs it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2461] [PySpark] Add a toString method t...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2625#issuecomment-58098773
LGTM, so I've merged this. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2461] [PySpark] Add a toString method t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2625#issuecomment-57598737
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21186/consoleFull) for PR 2625 at commit [`3544aad`](https://github.com/apache/spark/commit/3544aad2bd5fe691d72db930112252914e63cc5b).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` println(s"Failed to load main class $childMainClass.")`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2461] [PySpark] Add a toString method t...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2625#issuecomment-57598745
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21186/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2461] [PySpark] Add a toString method t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2625#issuecomment-57593293
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21186/consoleFull) for PR 2625 at commit [`3544aad`](https://github.com/apache/spark/commit/3544aad2bd5fe691d72db930112252914e63cc5b).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2461] [PySpark] Add a toString method t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org