You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sebastian Bauer (JIRA)" <ji...@apache.org> on 2010/07/06 19:25:50 UTC
[jira] Created: (HBASE-2814) Multi atomicIncreaments
Multi atomicIncreaments
-----------------------
Key: HBASE-2814
URL: https://issues.apache.org/jira/browse/HBASE-2814
Project: HBase
Issue Type: Improvement
Components: thrift
Affects Versions: 0.21.0
Reporter: Sebastian Bauer
Priority: Minor
Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
thanks
S.Bauer
PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2814) Multi atomicIncreaments
Posted by "Sebastian Bauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890383#action_12890383 ]
Sebastian Bauer commented on HBASE-2814:
----------------------------------------
after generate files by thrift -strict --gen java Hbase.thrift classes are without licence header, hashCode functions and with intendation errors, so i think this patch is better, its working with classes generated with thrift 0.2.0 for python
you can try regenerate classes in src/main/java/org/apache/hadoop/hbase/thrift/generated with thrift and you can see how it look
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2814) Multi atomicIncreaments
Posted by "Sebastian Bauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Bauer updated HBASE-2814:
-----------------------------------
Attachment: hbase.patch
rename IncreamentMutation as IncrementMutation
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2814) Multi atomicIncreaments
Posted by "Sebastian Bauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890187#action_12890187 ]
Sebastian Bauer commented on HBASE-2814:
----------------------------------------
I didn't use thrift, couse i don't know how to do this.
If you mean this files:
thrift/generated/IncrementMutation.java
thrift/generated/Hbase.java
i made this changes by modifying other code
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2814) Multi atomicIncreaments
Posted by "Sebastian Bauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Bauer updated HBASE-2814:
-----------------------------------
Status: Patch Available (was: Open)
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2814) Multi atomicIncreaments
Posted by "Sebastian Bauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890410#action_12890410 ]
Sebastian Bauer commented on HBASE-2814:
----------------------------------------
yes
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2814) Multi atomicIncreaments
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890408#action_12890408 ]
stack commented on HBASE-2814:
------------------------------
So, you are editing the generated files by hand?
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2814) Multi atomicIncreaments
Posted by "Sebastian Bauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888201#action_12888201 ]
Sebastian Bauer commented on HBASE-2814:
----------------------------------------
I'm sure that lines ar >80 chars and yes this patch is working and i'm using it for about week.
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2814) Multi atomicIncreaments
Posted by "Sebastian Bauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Bauer updated HBASE-2814:
-----------------------------------
Attachment: hbase.patch
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2814) Multi atomicIncreaments
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888003#action_12888003 ]
stack commented on HBASE-2814:
------------------------------
Hey Sebastian:
Patch looks good. Does it work for you?
FYI, we do 80 characters a line but, looks like the > 80 character lines are generated, is that right? So the patch includes the thrift generated code it seems?
Is this comment right? It doesn't seem to apply to IncrementMutation, your new class: + * A Mutation object is used to either update or delete a column-value.
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2814) Multi atomicIncreaments
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888418#action_12888418 ]
stack commented on HBASE-2814:
------------------------------
@Sebastian One other question... one version of thrift did you use generating classes? Was it thrift 0.2.0?
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2814) Multi atomicIncreaments
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890420#action_12890420 ]
stack commented on HBASE-2814:
------------------------------
You should not be editing anything under the 'generated' package by hand. Please use thrift to generate these classes as per the above cited link. Thanks.
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2814) Multi atomicIncreaments
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888180#action_12888180 ]
stack commented on HBASE-2814:
------------------------------
I can format for you (If generated classes are > 80 chars, thats not a problem). Does this patch work for you?
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2814) Multi atomicIncreaments
Posted by "Sebastian Bauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888019#action_12888019 ]
Sebastian Bauer commented on HBASE-2814:
----------------------------------------
It was my mistake when i copy Mutation class. About intendation and code style i dont now how to setup eclipse properly because when i change line width to 80 and make auto format when many other lines will change
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2814) Multi atomicIncreaments
Posted by "Sebastian Bauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Bauer updated HBASE-2814:
-----------------------------------
Attachment: hbase.patch
small changes in comments
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2814) Multi atomicIncreaments
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890355#action_12890355 ]
stack commented on HBASE-2814:
------------------------------
@Sebastien Your patch includes changes to classes that are usually generated by thrift. How were these generated class changes made?
See here http://hbase.apache.org/docs/r0.20.5/api/org/apache/hadoop/hbase/thrift/package-summary.html#package_description for a few notes on using thrift to generate code. Its important that you use the right version of thrift, the one that is bundled with hbase at least.
> Multi atomicIncreaments
> -----------------------
>
> Key: HBASE-2814
> URL: https://issues.apache.org/jira/browse/HBASE-2814
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.90.0
> Reporter: Sebastian Bauer
> Priority: Minor
> Attachments: hbase.patch, hbase.patch, hbase.patch
>
>
> Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.
> thanks
> S.Bauer
> PS. sorry for my bad english ;)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.