You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "mobuchowski (via GitHub)" <gi...@apache.org> on 2023/04/26 18:10:21 UTC
[GitHub] [airflow] mobuchowski opened a new pull request, #30888: openlineage: add (S)FTP extractors
mobuchowski opened a new pull request, #30888:
URL: https://github.com/apache/airflow/pull/30888
This PR adds (S)FTP extractors to OpenLineage provider.
As rest of currently open extractor PRs, this depends on https://github.com/apache/airflow/pull/30713, and will be rebased as soon as it's merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #30888: openlineage: add (S)FTP extractors
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #30888:
URL: https://github.com/apache/airflow/pull/30888#discussion_r1188026290
##########
airflow/providers/openlineage/extractors/__init__.py:
##########
@@ -20,4 +20,8 @@
from airflow.providers.openlineage.extractors.base import BaseExtractor, OperatorLineage
from airflow.providers.openlineage.extractors.manager import ExtractorManager
+"""
+:meta private:
+"""
Review Comment:
Why is the `__init__` file marked as private? Do we not want people to import from this file (but submodules instead?) and in that case, why are the classes re-exported from submodules into this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mobuchowski closed pull request #30888: openlineage: add (S)FTP extractors
Posted by "mobuchowski (via GitHub)" <gi...@apache.org>.
mobuchowski closed pull request #30888: openlineage: add (S)FTP extractors
URL: https://github.com/apache/airflow/pull/30888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #30888: openlineage: add (S)FTP extractors
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #30888:
URL: https://github.com/apache/airflow/pull/30888#discussion_r1188025867
##########
airflow/config_templates/config.yml:
##########
@@ -1221,7 +1221,14 @@ openlineage:
example: '{"type": "http", "url": "http://localhost:5000"}'
default: ''
version_added: ~
-
+ disable_source_code:
+ description: |
+ If disabled, OpenLineage events do not contain source code of particular
+ operators, like PythonOperator.
+ default: "True"
Review Comment:
Since this is disabled by default, I wonder if we should flip this into `add_source_code`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #30888: openlineage: add (S)FTP extractors
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30888:
URL: https://github.com/apache/airflow/pull/30888#discussion_r1188377178
##########
airflow/providers/openlineage/extractors/__init__.py:
##########
@@ -20,4 +20,8 @@
from airflow.providers.openlineage.extractors.base import BaseExtractor, OperatorLineage
from airflow.providers.openlineage.extractors.manager import ExtractorManager
+"""
+:meta private:
+"""
Review Comment:
Because this is just temporary. The idea was that first extractors will be added "as is" and then they will be merged into operators. This is what @mobuchowski plan is. We will not release openlineage provider (it is currently excluded from release) until this refactoring is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #30888: openlineage: add (S)FTP extractors
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #30888:
URL: https://github.com/apache/airflow/pull/30888#discussion_r1188026792
##########
airflow/providers/openlineage/extractors/bash.py:
##########
@@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+from airflow.providers.openlineage.extractors.base import BaseExtractor, OperatorLineage
+from airflow.providers.openlineage.plugins.facets import (
+ UnknownOperatorAttributeRunFacet,
+ UnknownOperatorInstance,
+)
+from airflow.providers.openlineage.utils.utils import is_source_enabled
+from openlineage.client.facet import SourceCodeJobFacet
+
+"""
+:meta private:
+"""
Review Comment:
I believe the general advice is to put the module-level docstring above the imports instead of below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #30888: openlineage: add (S)FTP extractors
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #30888:
URL: https://github.com/apache/airflow/pull/30888#discussion_r1188445183
##########
airflow/providers/openlineage/extractors/__init__.py:
##########
@@ -20,4 +20,8 @@
from airflow.providers.openlineage.extractors.base import BaseExtractor, OperatorLineage
from airflow.providers.openlineage.extractors.manager import ExtractorManager
+"""
+:meta private:
+"""
Review Comment:
The question then becomes why the imports are added to this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org