You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/09 18:30:42 UTC

[GitHub] [airflow] okue opened a new pull request, #28264: Fix helm chart NOTES.txt to show correct URL

okue opened a new pull request, #28264:
URL: https://github.com/apache/airflow/pull/28264

   ## What happened
   `breeze k8s deploy-airflow --upgrade` results is
   
   <img width="450" alt="image" src="https://user-images.githubusercontent.com/13622816/206767539-2e1aae5d-8b7f-499c-b5cc-03663b0943b7.png">
   
   with `values.yaml` shown below.
   
   ```yaml
   ingress:
     web:
       enabled: true
       annotations: {}
       path: "/"
       pathType: "ImplementationSpecific"
       hosts:
        - name: "localhost"
          tls:
            enabled: false
            secretName: ""
   ```
   
   Airflow Webserver URL is incorrect.
   
   
   ## What you think should happen instead
   
   ```
   Airflow Webserver:
         http:////
   ```
   
   should be
   
   ```
   Airflow Webserver:
         http://localhost/{path}/
   ```
   
   
   ## Modifications in this PR
   - Fix NOTES.txt
   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message: http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28264: Fix helm chart NOTES.txt to show correct URL

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28264:
URL: https://github.com/apache/airflow/pull/28264#issuecomment-1387451731

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #28264: Fix helm chart NOTES.txt to show correct URL

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28264:
URL: https://github.com/apache/airflow/pull/28264


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28264: Fix helm chart NOTES.txt to show correct URL

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28264:
URL: https://github.com/apache/airflow/pull/28264#issuecomment-1344628731

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] okue commented on pull request #28264: Fix helm chart NOTES.txt to show correct URL

Posted by GitBox <gi...@apache.org>.
okue commented on PR #28264:
URL: https://github.com/apache/airflow/pull/28264#issuecomment-1347675486

   @dstandish @jedcunningham could you please review? 🙇 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org