[GitHub] zhaijack opened a new issue #1118: Let `ConsumerImpl` and `ProducerImpl` directly extends `HandlerBase`

[GitBox <gi...@apache.org>]

zhaijack opened a new issue #1118: Let `ConsumerImpl` and `ProducerImpl` directly extends `HandlerBase`
URL: https://github.com/apache/incubator-pulsar/issues/1118
 
 
   This is a potential improvement of code.
   
   In Pulsar client code, class `HandlerBase` handles client_cnx and connection establishment, these operations is mainly serving single `ConsumerImpl` and `ProducerImpl`, while `HandlerBase ` useless to `PartitionedConsumerImpl` and `PartitionedProducerImpl`.
   
   Currently `ConsumerBase` and `ProducerBase` extends `HandlerBase`, so all Consumer and Producer  Impl(Partitioned or not) indirectly extends  `HandlerBase`.
   It may be better to let only `ConsumerImpl` and `ProducerImpl` directly extends `HandlerBase`, while let `PartitionedConsumerImpl` and `PartitionedProducerImpl` not extends  `HandlerBase`.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services