You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/08/13 01:34:47 UTC

Review Request 37422: Added a persistent volume test for linux filesystem isolator to test case where the container does not specify a root filesystem.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37422/
-----------------------------------------------------------

Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vinod Kone, and Jiang Yan Xu.


Repository: mesos


Description
-------

Added a persistent volume test for linux filesystem isolator to test case where the container does not specify a root filesystem.


Diffs
-----

  src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37422/diff/


Testing
-------

sudo make check


Thanks,

Jie Yu


Re: Review Request 37422: Added a persistent volume test for linux filesystem isolator to test case where the container does not specify a root filesystem.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37422/#review95205
-----------------------------------------------------------

Ship it!


Ideally we can verify in both cases the host mount table is "clean" after the container terminates?

- Jiang Yan Xu


On Aug. 12, 2015, 4:34 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37422/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2015, 4:34 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
>     https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a persistent volume test for linux filesystem isolator to test case where the container does not specify a root filesystem.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37422/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 37422: Added a persistent volume test for linux filesystem isolator to test case where the container does not specify a root filesystem.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37422/
-----------------------------------------------------------

(Updated Aug. 12, 2015, 11:34 p.m.)


Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vinod Kone, and Jiang Yan Xu.


Bugs: MESOS-2794
    https://issues.apache.org/jira/browse/MESOS-2794


Repository: mesos


Description
-------

Added a persistent volume test for linux filesystem isolator to test case where the container does not specify a root filesystem.


Diffs
-----

  src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37422/diff/


Testing
-------

sudo make check


Thanks,

Jie Yu