[jira] [Commented] (INFRA-10084) ORC github integration doesn't close pull requests

["Geoffrey Corey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/INFRA-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660336#comment-14660336 ] 

Geoffrey Corey commented on INFRA-10084:
----------------------------------------

On the GitHub side, using commits to close pull requests only work against the "default" branch, which as you noted was asf-site. I have since changed ORC's default branch to master.

Using commits to close pull requests against master should now work (and hopefully it will go back and close any open PRs that should be closed).

> ORC github integration doesn't close pull requests
> --------------------------------------------------
>
>                 Key: INFRA-10084
>                 URL: https://issues.apache.org/jira/browse/INFRA-10084
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: Git
>            Reporter: Owen O'Malley
>
> When we push commits to our repo at Apache, it never closes the pull requests on github. For example:
> https://github.com/apache/orc/pull/6
> My understanding is that both of the last commits to master should have closed the pull request (95a5b37 and 908a915).
> Are we doing something wrong?
> Also can we change the default branch at github to be master instead of asf-site?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)