You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2014/09/16 01:16:35 UTC
Review Request 25675: Make casting of constants more type specific
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25675/
-----------------------------------------------------------
Review request for hive and John Pullokkaran.
Bugs: HIVE-8110
https://issues.apache.org/jira/browse/HIVE-8110
Repository: hive-git
Description
-------
Make casting of constants more type specific
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTBuilder.java bfa4255
Diff: https://reviews.apache.org/r/25675/diff/
Testing
-------
vector_decimal_math_funcs.q
Thanks,
Ashutosh Chauhan
Re: Review Request 25675: Make casting of constants more type specific
Posted by John Pullokkaran <jp...@hortonworks.com>.
> On Sept. 15, 2014, 11:27 p.m., John Pullokkaran wrote:
> > Ship It!
make sure cbo correctness passes
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25675/#review53437
-----------------------------------------------------------
On Sept. 15, 2014, 11:16 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25675/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 11:16 p.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Bugs: HIVE-8110
> https://issues.apache.org/jira/browse/HIVE-8110
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Make casting of constants more type specific
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTBuilder.java bfa4255
>
> Diff: https://reviews.apache.org/r/25675/diff/
>
>
> Testing
> -------
>
> vector_decimal_math_funcs.q
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>
Re: Review Request 25675: Make casting of constants more type specific
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25675/#review53437
-----------------------------------------------------------
Ship it!
Ship It!
- John Pullokkaran
On Sept. 15, 2014, 11:16 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25675/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 11:16 p.m.)
>
>
> Review request for hive and John Pullokkaran.
>
>
> Bugs: HIVE-8110
> https://issues.apache.org/jira/browse/HIVE-8110
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Make casting of constants more type specific
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTBuilder.java bfa4255
>
> Diff: https://reviews.apache.org/r/25675/diff/
>
>
> Testing
> -------
>
> vector_decimal_math_funcs.q
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>