You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/12 09:37:00 UTC
[GitHub] [netbeans] JaroslavTulach opened a new pull request #2757: Avoid autoupdating existing NetBeans modules.
JaroslavTulach opened a new pull request #2757:
URL: https://github.com/apache/netbeans/pull/2757
Gregor Kováč [reported problems on subsequent start of VSNetBeans](https://lists.apache.org/thread.html/r07d0861858590e3a047d284d1443b8794912f4caeb231a3de19efedc%40%3Cusers.netbeans.apache.org%3E) and we have tracked down the problem to autoupdate!
There is `updatecenters` module in VSNetBeans since 90d2af9 - it is needed to install `nbjavac` on JDK8. However it also provides other update centers.
There is code checking whether Apache NetBeans `java.lsp.server` module is properly started. It [uses a regexp](https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/src/extension.ts#L350) to parse the output and searches for:
```ts
stdOut.match(/org.netbeans.modules.java.lsp.server.*Enabled/)
```
However, since recently there has been a release of updates and the output now says:
```
org.netbeans.modules.java.lsp.server 1.6.1.1.1.12.1.17.32.5.2.1.1.1.13
Upgrade to 1.7.0.1.1.12.1.17.32.5.2.1.1.1.13
```
the existing regexp doesn't match this output and as such VSCode never connects to the Apache NetBeans LSP server now!
This PR disables the other update centers. It should also change the regexp, I guess.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach merged pull request #2757: Avoid autoupdating existing NetBeans modules.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach merged pull request #2757:
URL: https://github.com/apache/netbeans/pull/2757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2757: Avoid autoupdating existing NetBeans modules.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2757:
URL: https://github.com/apache/netbeans/pull/2757#issuecomment-778216551
OK, as mentioned on dev@ it looks like the 12.2.1 update was released with a link to the dev UC, which as of a few weeks ago points to the daily builds - it was pointing at 12.2. That shouldn't happen, and is probably because an entry was missed in https://github.com/apache/netbeans-jenkins-lib/blob/master/meta/netbeansrelease.json#L307
So, yes, getting this fix in looks good assuming you don't want external UCs, even if it should be mitigated by correct release process.
cc/ @geertjanw this answers the nb-javac in VSCode question from the other day then! :smile:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2757: Avoid autoupdating existing NetBeans modules.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2757:
URL: https://github.com/apache/netbeans/pull/2757#issuecomment-778730258
There are some failing javac related builds, but those failures are unlikely associated with this PR. I am merging this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] MartinBalin commented on pull request #2757: Avoid autoupdating existing NetBeans modules.
Posted by GitBox <gi...@apache.org>.
MartinBalin commented on pull request #2757:
URL: https://github.com/apache/netbeans/pull/2757#issuecomment-778127133
I've seen this issue and it is completely breaking VSCode NetBeans ext. It was there around 10am here and it was gone 1 hour later.
At 10am I could see this output fro VSCode NB
`org.netbeans.modules.java.lsp.server 1.6.1.1.1.12.1.17.32.5.2.1.1.1.13 Upgrade to 1.7.0.1.1.12.1.17.32.5.2.1.1.1.13`
When I downloaded distribution center catalog from NB 12.2 now https://netbeans.apache.org/nb/updates/12.2/updates.xml.gz it lists `1.6.0.1.1.12.1.17.5.2.13` version.
Seems like someone is playing with catalogs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists