[GitHub] [drill] vdiravka commented on a change in pull request #1681: DRILL-7051: Upgrade to Jetty 9.3

[GitBox <gi...@apache.org>]

vdiravka commented on a change in pull request #1681: DRILL-7051: Upgrade to Jetty 9.3 
URL: https://github.com/apache/drill/pull/1681#discussion_r269085173
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -2553,7 +2548,13 @@
             <version>4.0.1</version>
             <scope>provided</scope>
           </dependency>
-          <!--/Javax Servlet dependecies-->
+
+          <dependency>
+            <groupId>javax.ws.rs</groupId>
+            <artifactId>javax.ws.rs-api</artifactId>
 
 Review comment:
   This is versions control for `javax` transitive dependencies from `jersey` dependencies, since they are also widely used in Drill.
   I have updated them to the latest versions along with `jersey` dependencies.
   But after reading some good practices, I rethought it. It is better to control only `jersey` dependencies. Since `javax.ws` can have an interfaces, which are not implemented in Jersey yet.
   So I removed this `javax` versions control mechanism 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services