You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Yaroslav Panych <pa...@gmail.com> on 2015/03/14 19:39:42 UTC

Exception: libsvn_wc\update_editor.c line 1550: assertion failed (action == svn_wc_conflict_action_delete)

Hello devs.
Got Tsvn exception while updating repository frim github (
https://github.com/cplussharp/graph-studio-next/)
Actually it happens if initial checkout from repo was canceled by user(for
some reason) and then(after cleanup command) user initiated update command.
If checkout perforemed to the end, next update commands work(well, not
found case yet).

>---------------------------
>Subversion Exception!
>---------------------------
>Subversion encountered a serious problem.
>Please take the time to report this on the Subversion mailing list
>with as much information as possible about what
>you were trying to do.
>But please first search the mailing list archives for the error message
>to avoid reporting the same problem repeatedly.
>You can find the mailing list archives at
>http://subversion.apache.org/mailing-lists.html
>
>Subversion reported the following
>(you can copy the content of this dialog
>to the clipboard using Ctrl-C):
>
>In file
 >'D:\Development\SVN\Releases\TortoiseSVN-1.8.10\ext\subversion\subversion\libsvn_wc\update_editor.c'
 >line 1550: assertion failed (action == svn_wc_conflict_action_delete)

Re: Exception: libsvn_wc\update_editor.c line 1550: assertion failed (action == svn_wc_conflict_action_delete)

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Bert Huijben wrote on Sun, Mar 15, 2015 at 10:08:00 +0000:
> Yes, we probably should.
> 

Looks like you just did, in r1666832.  Thanks.  Nominate it for backport?

% nominate.pl r1666832 "Resolves an assertion"

:-)

Daniel

> 
> The problem here is an editor that drives a file or directory add in a location that already has a BASE (‘status normal’) node. That should never happen, because the reporter just told the server that this node is there).
> 
> 
> But github only uses some bits of the reporter state. (It doesn’t fully support clients that have mixed revision, potentially switched, sparse and in this case incomplete working copies. The incomplete is not the root problem here. The problem is not using the reporter state)
> 
> 
> 
> 
> 
> 
> Bert
> 
> 
> 
> 
> Sent from Windows Mail
> 
> 
> 
> 
> 
> From: Ivan Zhakov
> Sent: ‎Sunday‎, ‎March‎ ‎15‎, ‎2015 ‎9‎:‎09‎ ‎AM
> To: Bert Huijben
> Cc: 'Yaroslav Panych', 'subversion'
> 
> 
> 
> 
> 
> On 14 March 2015 at 22:57, Bert Huijben <be...@qqmail.nl> wrote:
> >                 Hi,
> >
> > Thanks for noting that this is related to the github implementation.
> >
> > When Subversion recovers from an so called ‘incomplete’ update, it sends
> > other information to the server, but the github Subversion compatibility
> > code doesn’t properly implement this recovery code path. (Their server also
> > has problems handling sparse working copies… something that is not possible
> > in plain git)
> >
> >
> >
> > There is not much we can do here in Subversion, as this is technically a
> > protocol violation. But if github needs more information for fixing this
> > please let them contact me.
> >
> >
> Hi Bert,
> 
> I didn't look to the code, but is it possible to replace assertion
> with some error message for this case?
> 
> 
> -- 
> Ivan Zhakov

Re: Exception: libsvn_wc\update_editor.c line 1550: assertion failed (action == svn_wc_conflict_action_delete)

Posted by Bert Huijben <be...@qqmail.nl>.
Yes, we probably should.


The problem here is an editor that drives a file or directory add in a location that already has a BASE (‘status normal’) node. That should never happen, because the reporter just told the server that this node is there).


But github only uses some bits of the reporter state. (It doesn’t fully support clients that have mixed revision, potentially switched, sparse and in this case incomplete working copies. The incomplete is not the root problem here. The problem is not using the reporter state)






Bert




Sent from Windows Mail





From: Ivan Zhakov
Sent: ‎Sunday‎, ‎March‎ ‎15‎, ‎2015 ‎9‎:‎09‎ ‎AM
To: Bert Huijben
Cc: 'Yaroslav Panych', 'subversion'





On 14 March 2015 at 22:57, Bert Huijben <be...@qqmail.nl> wrote:
>                 Hi,
>
> Thanks for noting that this is related to the github implementation.
>
> When Subversion recovers from an so called ‘incomplete’ update, it sends
> other information to the server, but the github Subversion compatibility
> code doesn’t properly implement this recovery code path. (Their server also
> has problems handling sparse working copies… something that is not possible
> in plain git)
>
>
>
> There is not much we can do here in Subversion, as this is technically a
> protocol violation. But if github needs more information for fixing this
> please let them contact me.
>
>
Hi Bert,

I didn't look to the code, but is it possible to replace assertion
with some error message for this case?


-- 
Ivan Zhakov

Re: Exception: libsvn_wc\update_editor.c line 1550: assertion failed (action == svn_wc_conflict_action_delete)

Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 14 March 2015 at 22:57, Bert Huijben <be...@qqmail.nl> wrote:
>                 Hi,
>
> Thanks for noting that this is related to the github implementation.
>
> When Subversion recovers from an so called ‘incomplete’ update, it sends
> other information to the server, but the github Subversion compatibility
> code doesn’t properly implement this recovery code path. (Their server also
> has problems handling sparse working copies… something that is not possible
> in plain git)
>
>
>
> There is not much we can do here in Subversion, as this is technically a
> protocol violation. But if github needs more information for fixing this
> please let them contact me.
>
>
Hi Bert,

I didn't look to the code, but is it possible to replace assertion
with some error message for this case?


-- 
Ivan Zhakov

RE: Exception: libsvn_wc\update_editor.c line 1550: assertion failed (action == svn_wc_conflict_action_delete)

Posted by Bert Huijben <be...@qqmail.nl>.
                Hi,

 

Thanks for noting that this is related to the github implementation.

 

When Subversion recovers from an so called ‘incomplete’ update, it sends other information to the server, but the github Subversion compatibility code doesn’t properly implement this recovery code path. (Their server also has problems handling sparse working copies… something that is not possible in plain git)

 

There is not much we can do here in Subversion, as this is technically a protocol violation. But if github needs more information for fixing this please let them contact me.

 

                Bert

 

From: panychy@gmail.com [mailto:panychy@gmail.com] On Behalf Of Yaroslav Panych
Sent: zaterdag 14 maart 2015 19:40
To: users@subversion.apache.org
Subject: Exception: libsvn_wc\update_editor.c line 1550: assertion failed (action == svn_wc_conflict_action_delete)

 

Hello devs.

Got Tsvn exception while updating repository frim github (https://github.com/cplussharp/graph-studio-next/)

Actually it happens if initial checkout from repo was canceled by user(for some reason) and then(after cleanup command) user initiated update command. If checkout perforemed to the end, next update commands work(well, not found case yet). 

 

>---------------------------
>Subversion Exception!
>---------------------------
>Subversion encountered a serious problem.
>Please take the time to report this on the Subversion mailing list
>with as much information as possible about what
>you were trying to do.
>But please first search the mailing list archives for the error message
>to avoid reporting the same problem repeatedly.
>You can find the mailing list archives at
>http://subversion.apache.org/mailing-lists.html
>
>Subversion reported the following
>(you can copy the content of this dialog
>to the clipboard using Ctrl-C):
>
>In file
 >'D:\Development\SVN\Releases\TortoiseSVN-1.8.10\ext\subversion\subversion\libsvn_wc\update_editor.c'
 >line 1550: assertion failed (action == svn_wc_conflict_action_delete)