[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

["Jun Rao (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245568#comment-13245568 ] 

Jun Rao commented on KAFKA-49:
------------------------------

Prashanth,

Patch looks good: Just one minor thing.

6. Unused imports: KafkaZookeeper

While looking at the patch, I realized that there are a couple of other things that we will need to follow up.

a. In DefaultEventHandler, it seems that we rely on the fact that broker.id is a non-negative integer. However, we don't enforce that in broker startup.
b. With the create topic ddl, some of the broker configs like topic.partition.count.map probably don't make sense anymore.

I will create a jira for each item to follow up.
                
> Add acknowledgement to the produce request.
> -------------------------------------------
>
>                 Key: KAFKA-49
>                 URL: https://issues.apache.org/jira/browse/KAFKA-49
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Prashanth Menon
>             Fix For: 0.8
>
>         Attachments: KAFKA-49-continued.patch, KAFKA-49-v1.patch, KAFKA-49-v2.patch, KAFKA-49-v3.patch
>
>
> Currently, the produce request doesn't get acknowledged. We need to have a broker send a response to the producer and have the producer wait for the response before sending the next request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira